Skip to content

fix: enable fullscreen support for all titleBarStyle options #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
raymondreaming wants to merge 1 commit into from
Closed

fix: enable fullscreen support for all titleBarStyle options #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions package/src/native/macos/nativeWrapper.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7041,6 +7041,15 @@ - (BOOL)canBecomeMainWindow { return YES; }
screen:primaryScreen];

[window setFrameTopLeftPoint:config.frame.origin];

// Enable native fullscreen support for all window styles.
// Without this, [window toggleFullScreen:nil] is silently ignored
// because macOS requires NSWindowCollectionBehaviorFullScreenPrimary
// in the window's collectionBehavior.
[window setCollectionBehavior:
NSWindowCollectionBehaviorFullScreenPrimary |
NSWindowCollectionBehaviorMoveToActiveSpace];

if (strcmp(config.titleBarStyle, "hiddenInset") == 0) {
window.titlebarAppearsTransparent = YES;
window.titleVisibility = NSWindowTitleHidden;
Expand Down