Skip to content

feat(macos): add CEF support to setPageZoom/getPageZoom #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
COCPORN wants to merge 1 commit into from
+24 −0
Closed

feat(macos): add CEF support to setPageZoom/getPageZoom #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions package/src/native/macos/nativeWrapper.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6986,6 +6986,14 @@ - (void)windowDidResignKey:(NSNotification *)notification {
[wkImpl.webView setNeedsDisplay:YES];
[wkImpl.webView setNeedsLayout:YES];
}
} else if ([abstractView isKindOfClass:[CEFWebViewImpl class]]) {
CEFWebViewImpl *cefImpl = (CEFWebViewImpl *)abstractView;
if (cefImpl.browser && cefImpl.browser->GetHost()) {
// CEF zoom is logarithmic (base 1.2): 0.0 = 100%, 1.0 ≈ 120%
// Convert linear zoom (1.0 = 100%, 1.5 = 150%) to CEF scale
double cefZoomLevel = log(zoomLevel) / log(1.2);
cefImpl.browser->GetHost()->SetZoomLevel(cefZoomLevel);
}
}
});
}
Expand All @@ -7003,6 +7011,22 @@ - (void)windowDidResignKey:(NSNotification *)notification {
});
}
}
} else if ([abstractView isKindOfClass:[CEFWebViewImpl class]]) {
CEFWebViewImpl *cefImpl = (CEFWebViewImpl *)abstractView;
if (cefImpl.browser && cefImpl.browser->GetHost()) {
double cefZoomLevel;
if ([NSThread isMainThread]) {
cefZoomLevel = cefImpl.browser->GetHost()->GetZoomLevel();
} else {
__block double level;
dispatch_sync(dispatch_get_main_queue(), ^{
level = cefImpl.browser->GetHost()->GetZoomLevel();
});
cefZoomLevel = level;
}
// Convert CEF logarithmic zoom back to linear
zoomLevel = pow(1.2, cefZoomLevel);
}
}
return zoomLevel;
}
Expand Down