Skip to content

fix: tempo slider behavior #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
areohbe wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: tempo slider behavior #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d02506e
fix slider
areohbe Mar 16, 2026
d1e52f7
Merge branch 'develop' into fix-tempo-slider
maxwellmattryan Mar 23, 2026
45b589c
Merge branch 'develop' into fix-tempo-slider
maxwellmattryan Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/lib/components/common/Slider.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,27 @@
return `background: linear-gradient(to right, var(--brand-primary) 0%, var(--brand-primary) ${percentage}%, var(--stroke) ${percentage}%, var(--stroke) 100%)`
})

function handleInput(e: Event) {
function applySnap(e: Event): void {
if (snapToCenter !== undefined) {
const target = e.target as HTMLInputElement
const raw = parseFloat(target.value)
const mid = (min + max) / 2
if (Math.abs(value - mid) <= snapToCenter) {
if (Math.abs(raw - mid) <= snapToCenter) {
value = mid
;(e.target as HTMLInputElement).value = String(mid)
target.value = String(mid)
}
}
}

function handleInput(e: Event) {
applySnap(e)
oninput?.(e)
}

function handleChange(e: Event) {
applySnap(e)
onchange?.(e)
}
</script>

<input
Expand All @@ -59,7 +70,7 @@
class="h-1.5 w-full cursor-pointer appearance-none rounded-full bg-surface-2 disabled:cursor-not-allowed disabled:opacity-50 {className}"
style={backgroundStyle}
oninput={handleInput}
{onchange}
onchange={handleChange}
/>

<style>
Expand Down
1 change: 1 addition & 0 deletions src/lib/stores/player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,7 @@ function createPlayerStore() {
setStoredNumber('player.speed', speed)

if (state.playbackSource === 'preview') {
previewPlayer.setPlaybackRate(speed)
update((s) => ({
...s,
playbackState: { ...s.playbackState, speed },
Expand Down