Dev/shanty/idetect 5161 remove centos support - #23
Open
shantyk wants to merge 7 commits into
Open
Conversation
shantyk
commented
Jul 29, 2026
shantyk
marked this pull request as ready for review
July 29, 2026 05:50
| String correctImageInspectorOsName = response.getBody().trim(); | ||
|
|
||
| // Safety net: CentOS-based inspection is no longer supported | ||
| if ("CENTOS".equalsIgnoreCase(correctImageInspectorOsName)) { |
Collaborator
There was a problem hiding this comment.
Could we use static final constant here as we do for most of the cases when comparing strings?
zahidblackduck
approved these changes
Jul 29, 2026
dterrybd
approved these changes
Jul 29, 2026
| if ("CENTOS".equalsIgnoreCase(correctImageInspectorOsName)) { | ||
| logger.warn("This image requires CentOS-based (rpm) inspection, which is no longer supported. " + | ||
| "rpm-based images (CentOS, RHEL, Fedora, Rocky Linux, AlmaLinux, etc.) are treated as unsupported. " + | ||
| "Upgrade the imageinspector service to a version that handles rpm-based images gracefully."); |
Collaborator
There was a problem hiding this comment.
I'm not sure we want this line? It kind of implies that we could handle rpm images? I think all we can do is report we can't handle them so maybe just leave it with the previous message that they are unsupported?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull is downstream changes from: