Skip to content
This repository was archived by the owner on Oct 22, 2020. It is now read-only.

Feature/background and predefined title#9

Open
rsrbk wants to merge 9 commits intoblackmirror-media:release/1.3.0from
rsrbk:feature/background_and_predefined_title
Open

Feature/background and predefined title#9
rsrbk wants to merge 9 commits intoblackmirror-media:release/1.3.0from
rsrbk:feature/background_and_predefined_title

Conversation

@rsrbk
Copy link

@rsrbk rsrbk commented Oct 22, 2016

  • Added property predefinedText for setting up the text for the field.
  • Added property isBackgroundBlurred, if true - it'll show the blur background below the alert.
    img_1956 png

Copy link
Member

@eriadam eriadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Ruslan,

Thanks for this, I like these features a lot. Adding a placeholder was a bit cumbersome, this solves the issue. The blur background is a great idea as well.

Could you please have a look and rebase your changes at the 1.3.0 branch, I already addressed the Swift 3 things. I will have a look at the new open/public thing, it makes sense to add 'open' to a few places.

  • Can you please stick to the 2 space indent?
  • Would you please rename the "predefinedText" to "placeholder" as it is a UITextField after all.
  • And kindly update the readme.md file with the new features.

Thanks again,
Adam

@eriadam
Copy link
Member

eriadam commented Nov 27, 2016

@rsrbk Are you planning to continue with this?

@rsrbk
Copy link
Author

rsrbk commented Nov 28, 2016

@eriadam oh, sorry about that, I forgot. Will do it today!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants