Remove Category xdist serialization/deserialization#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the custom serialization (save) and deserialization (load) methods for the Category enum, as well as the StrEnum base class for Category. Instead, Category is redefined using a metaclass (CategoryMeta) to provide iteration capabilities while being fundamentally a plain string type.
The primary motivation is to simplify the data types used for communication between master and worker processes in xdist. The Category type is now represented as a simple str in type hints (CategoryT = str in typing.pyi), removing the need for explicit serialization steps when sending CategoryMeasurementsT dictionaries over the wire. The dump_measurements function now simply passes the dictionary through, and load_measurements uses the string keys directly as dictionary keys for the destination.
This change aims to make the xdist communication more robust and efficient by relying on native, serializable types.