Open
Conversation
aelaa
commented
May 11, 2020
| @@ -546,15 +546,15 @@ if Code.ensure_loaded?(Postgrex) do | |||
| defp create_names(prefix, sources, pos, limit) when pos < limit do | |||
| current = | |||
| case elem(sources, pos) do | |||
Author
There was a problem hiding this comment.
Very strange one. As case should work, it should match {table, schema, _alias} pattern even if there is :fragment in the beginning. That somehow worked in the original code, and had been broken after dependencies updating.
aelaa
commented
May 11, 2020
| end | ||
|
|
||
| defp from(%{from: from} = query, sources) do | ||
| defp from(%{from: %Ecto.Query.FromExpr{source: from}} = query, sources) do |
Author
There was a problem hiding this comment.
Ecto 3 introduced FromExpr contains source: SubQuery, unlike just SubQuery like before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Allen! I was looking for ecto 3 support for 2 years (wasn't confident enough to write it myself), so I appreciate your work on it! Let me help you finish it, and I hope the maintainer of the original repo accept it. I'll push my progress here, and remove WIP tag when everything's done