Update trading branch

[jeffersonBastos]

This PR updates the trading package, which is currently open on the CoW side.

[linear]

COW-480 Create umbrella package

[github-actions]

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​nicolo-ribaudo/​eslint-scope-5-internals@​5.1.1-v1
	array-buffer-byte-length@​1.0.0
	array.prototype.tosorted@​1.1.1
	abab@​2.0.6
	array.prototype.flat@​1.3.1
	array.prototype.reduce@​1.0.5
	array.prototype.flatmap@​1.3.1
	@​types/​parse-json@​4.0.0
	assert@​2.1.0
	array-includes@​3.1.6
	@​jest/​globals@​27.5.1
	at-least-node@​1.0.0
	@​babel/​plugin-transform-react-jsx-development@​7.18.6
	@​tootallnate/​once@​1.1.2
	babel-plugin-named-asset-import@​0.3.8
	@​babel/​plugin-syntax-async-generators@​7.8.4
	@​babel/​plugin-syntax-bigint@​7.8.3
	@​babel/​plugin-syntax-import-meta@​7.10.4
	@​babel/​plugin-syntax-json-strings@​7.8.3
	@​babel/​plugin-syntax-logical-assignment-operators@​7.10.4
	@​babel/​plugin-syntax-nullish-coalescing-operator@​7.8.3
	@​babel/​plugin-syntax-numeric-separator@​7.10.4
	@​babel/​plugin-syntax-object-rest-spread@​7.8.3
	@​babel/​plugin-syntax-optional-catch-binding@​7.8.3
	@​babel/​plugin-syntax-optional-chaining@​7.8.3
	@​babel/​plugin-syntax-dynamic-import@​7.8.3
	@​babel/​plugin-syntax-export-namespace-from@​7.8.3
	@​babel/​plugin-syntax-private-property-in-object@​7.14.5
	@​babel/​plugin-transform-dotall-regex@​7.18.6
	@​babel/​plugin-transform-unicode-regex@​7.18.6
	@​svgr/​babel-plugin-remove-jsx-empty-expression@​5.0.1
	@​babel/​plugin-syntax-class-properties@​7.12.13
	@​babel/​plugin-syntax-class-static-block@​7.14.5
	@​babel/​plugin-syntax-top-level-await@​7.14.5
See 233 more rows in the dashboard

View full report

[cursor]

Bug: Misleading Optional Properties Initialization

Type inconsistency: The cowShed, trading, and composable properties are declared as optional (?) but are always initialized in the constructor. This makes their optional typing misleading, as they will never be undefined at runtime.

packages/sdk/src/CowSdk.ts#L32-L38

cow-sdk/packages/sdk/src/CowSdk.ts

Lines 32 to 38 in e05e377

	public readonly contracts: ContractsTs
	public readonly cowShed?: CowShedSdk
	public readonly trading?: TradingSdk
	public readonly composable?: {
	factory: ConditionalOrderFactory
	multiplexer?: Multiplexer
	}

Fix in Cursor

---

Was this report helpful? Give feedback by reacting with 👍 or 👎