Bugfixes in router_result.c#175
Open
PaulWagener wants to merge 2 commits intobliksemlabs:tdata4from
Open
Conversation
`check_plan_invariants()` returns *true* if there is a fail, while `router_result_to_plan()` returns *false* if there is a fail. Hence the need to invert the output before returning.
These prevent every single plan from failing the invariants checking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You might want to hold off on merging these bugfixes. Currently almost all plans do not pass the invariants which will result in no output to the user.
In the previous situation two bugs cancelled each other out resulting in all plans being valid.