chore(deps): bump stablesats proto#450
Closed
blinkbitcoinbot wants to merge 1 commit intomainfrom
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the generated JavaScript protobuf + gRPC stubs for the dealer-price PriceService, consistent with a “bump stablesats proto” dependency refresh.
Changes:
- Regenerated
price_service_pb.jsmessage code (notably thetoObject()output formatting). - Updated
price_service_grpc_pb.jsto pass an explicit service name togrpc.makeGenericClientConstructor.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 34 comments.
| File | Description |
|---|---|
| core/api/src/services/dealer-price/proto/services/price/v1/price_service_pb.js | Regenerated protobuf JS message definitions for PriceService types. |
| core/api/src/services/dealer-price/proto/services/price/v1/price_service_grpc_pb.js | Regenerated gRPC client/service bindings; adds explicit 'PriceService' name to the client constructor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -449,7 +449,7 @@ proto.services.price.v1.GetCentsFromSatsForImmediateBuyRequest.prototype.toObjec | |||
| */ | |||
| proto.services.price.v1.GetCentsFromSatsForImmediateBuyRequest.toObject = function(includeInstance, msg) { | |||
There was a problem hiding this comment.
'proto' is not defined.
| @@ -449,7 +449,7 @@ proto.services.price.v1.GetCentsFromSatsForImmediateBuyRequest.prototype.toObjec | |||
| */ | |||
| proto.services.price.v1.GetCentsFromSatsForImmediateBuyRequest.toObject = function(includeInstance, msg) { | |||
| var f, obj = { | |||
There was a problem hiding this comment.
'f' is defined but never used.
Suggested change
| var f, obj = { | |
| var obj = { |
| @@ -579,7 +579,7 @@ proto.services.price.v1.GetCentsFromSatsForImmediateBuyResponse.prototype.toObje | |||
| */ | |||
| proto.services.price.v1.GetCentsFromSatsForImmediateBuyResponse.toObject = function(includeInstance, msg) { | |||
There was a problem hiding this comment.
'proto' is not defined.
| @@ -579,7 +579,7 @@ proto.services.price.v1.GetCentsFromSatsForImmediateBuyResponse.prototype.toObje | |||
| */ | |||
| proto.services.price.v1.GetCentsFromSatsForImmediateBuyResponse.toObject = function(includeInstance, msg) { | |||
| var f, obj = { | |||
There was a problem hiding this comment.
'f' is defined but never used.
Suggested change
| var f, obj = { | |
| var obj = { |
| @@ -709,7 +709,7 @@ proto.services.price.v1.GetCentsFromSatsForImmediateSellRequest.prototype.toObje | |||
| */ | |||
| proto.services.price.v1.GetCentsFromSatsForImmediateSellRequest.toObject = function(includeInstance, msg) { | |||
There was a problem hiding this comment.
'proto' is not defined.
| @@ -2359,8 +2359,8 @@ proto.services.price.v1.GetSatsFromCentsForFutureSellRequest.prototype.toObject | |||
| */ | |||
| proto.services.price.v1.GetSatsFromCentsForFutureSellRequest.toObject = function(includeInstance, msg) { | |||
| var f, obj = { | |||
There was a problem hiding this comment.
'f' is defined but never used.
Suggested change
| var f, obj = { | |
| var obj = { |
| @@ -2519,7 +2519,7 @@ proto.services.price.v1.GetSatsFromCentsForFutureSellResponse.prototype.toObject | |||
| */ | |||
| proto.services.price.v1.GetSatsFromCentsForFutureSellResponse.toObject = function(includeInstance, msg) { | |||
There was a problem hiding this comment.
'proto' is not defined.
| @@ -2519,7 +2519,7 @@ proto.services.price.v1.GetSatsFromCentsForFutureSellResponse.prototype.toObject | |||
| */ | |||
| proto.services.price.v1.GetSatsFromCentsForFutureSellResponse.toObject = function(includeInstance, msg) { | |||
| var f, obj = { | |||
There was a problem hiding this comment.
'f' is defined but never used.
Suggested change
| var f, obj = { | |
| var obj = { |
| @@ -2750,7 +2750,7 @@ proto.services.price.v1.GetCentsPerSatsExchangeMidRateResponse.prototype.toObjec | |||
| */ | |||
| proto.services.price.v1.GetCentsPerSatsExchangeMidRateResponse.toObject = function(includeInstance, msg) { | |||
There was a problem hiding this comment.
'proto' is not defined.
| @@ -2750,7 +2750,7 @@ proto.services.price.v1.GetCentsPerSatsExchangeMidRateResponse.prototype.toObjec | |||
| */ | |||
| proto.services.price.v1.GetCentsPerSatsExchangeMidRateResponse.toObject = function(includeInstance, msg) { | |||
| var f, obj = { | |||
There was a problem hiding this comment.
'f' is defined but never used.
Suggested change
| var f, obj = { | |
| var obj = { |
blinkbitcoinbot
force-pushed
the
bot-bump-stablesats-proto
branch
from
dfdd944 to
ee32188
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.