Use AGENTS.md for Firebender rules#90
Merged
Merged
Conversation
jonandersen
force-pushed
the
jonandersen/firebender-agents-md
branch
3 times, most recently
from
March 26, 2026 14:27
5c4492d to
fde29db
Compare
jonandersen
marked this pull request as ready for review
March 26, 2026 14:33
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fde29dbe2f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jonandersen
force-pushed
the
jonandersen/firebender-agents-md
branch
3 times, most recently
from
March 30, 2026 14:23
b5d58fe to
b6dbab2
Compare
Generate Firebender rules through AGENTS.md in both standard\nand symlink modes so it matches the rest of the shared agent\nflow.\n\nKeep firebender.json as supplemental MCP and overlay config,\nreuse the shared .agents/skills path for Firebender skills,\nand generate Firebender commands as .mdc symlinks.\n\nAlso update the docs, tests, and example gitignore entries to\nmatch the new Firebender layout. Signed-off-by: Jon Andersen <jonandersen@squareup.com>
jonandersen
force-pushed
the
jonandersen/firebender-agents-md
branch
from
March 30, 2026 14:35
b6dbab2 to
3bfc53f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Firebender now supports
AGENTS.md, so we should generate its rules in the same shape we use for other agents instead of encoding rule references infirebender.json.What
AGENTS.mdin both standard and symlink modes.firebender/commands/*-ai-rules.mdand.firebender/skills/ai-rules-generated-*symlinksfirebender.jsonas supplemental MCP/overlay config onlyGenerated with Codex