Skip to content

Use AGENTS.md for Firebender rules#90

Merged
jonandersen merged 1 commit into
mainfrom
jonandersen/firebender-agents-md
Mar 30, 2026
Merged

Use AGENTS.md for Firebender rules#90
jonandersen merged 1 commit into
mainfrom
jonandersen/firebender-agents-md

Conversation

@jonandersen

@jonandersen jonandersen commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

Why

Firebender now supports AGENTS.md, so we should generate its rules in the same shape we use for other agents instead of encoding rule references in firebender.json.

What

  • switch Firebender rule generation to AGENTS.md in both standard and symlink modes
  • generate .firebender/commands/*-ai-rules.md and .firebender/skills/ai-rules-generated-* symlinks
  • keep firebender.json as supplemental MCP/overlay config only
  • update docs and the example gitignore to match the new layout

Generated with Codex

@jonandersen
jonandersen force-pushed the jonandersen/firebender-agents-md branch 3 times, most recently from 5c4492d to fde29db Compare March 26, 2026 14:27
@jonandersen
jonandersen marked this pull request as ready for review March 26, 2026 14:33

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fde29dbe2f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/agents/firebender.rs
Comment thread src/agents/external_commands_generator.rs Outdated

@lifeizhou-ap lifeizhou-ap left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more cleaning 🔥

@jonandersen
jonandersen force-pushed the jonandersen/firebender-agents-md branch 3 times, most recently from b5d58fe to b6dbab2 Compare March 30, 2026 14:23
Generate Firebender rules through AGENTS.md in both standard\nand symlink modes so it matches the rest of the shared agent\nflow.\n\nKeep firebender.json as supplemental MCP and overlay config,\nreuse the shared .agents/skills path for Firebender skills,\nand generate Firebender commands as .mdc symlinks.\n\nAlso update the docs, tests, and example gitignore entries to\nmatch the new Firebender layout.

Signed-off-by: Jon Andersen <jonandersen@squareup.com>
@jonandersen
jonandersen force-pushed the jonandersen/firebender-agents-md branch from b6dbab2 to 3bfc53f Compare March 30, 2026 14:35
@jonandersen
jonandersen merged commit e48baac into main Mar 30, 2026
8 checks passed
@jonandersen
jonandersen deleted the jonandersen/firebender-agents-md branch March 30, 2026 14:44
@jonandersen jonandersen mentioned this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants