Retrieve username from secret in the hotswap driver function#159
Merged
Retrieve username from secret in the hotswap driver function#159
Conversation
JashLal
changed the title
aws/secret.go
Outdated
| return username.(string), nil | ||
| } | ||
|
|
||
| func (s Secret) Password(v map[string]interface{}) (string, error) { |
Contributor
There was a problem hiding this comment.
I don't think these 2 new method are needed; they're extremely shallow (see book Philosophy of Software Design). They can be put inline in the callback func (return func(ctx context.Context) (Credentials, error) {) so the reader doesn't have make a mental context switch. E.g. when I fist saw these 2 methods, I figured they served some kind of other purpose/did something else. It took me a moment to realize they're just fetching a value from a map that's passed into them--there's no additional logic or handling or anything else.
daniel-nichter
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the hotswap credentials function. Changes the logic for the
password-secretauthentication mode. Retrieves ausernamekey in addition topasswordand if found sets the mysql config.