feat(staged): make chat replies multiline and move Stop to the thinking row#874
Conversation
Composing a reply in the session chat now behaves like a multiline text input: Enter inserts a newline and Cmd/Ctrl+Enter sends the message. While the session is busy, the composer keeps its accent send button but labels it Queue (sending while live already queues a follow-up) instead of swapping in the stop button. Stopping now lives on a labeled Stop button on the right-hand side of the Thinking indicator row. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
Bump the Thinking-row Stop button from the xs to the sm size variant and scale its icon/spinner up to match. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4eb884379
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| <div class="thinking" in:messageSlide> | ||
| <Spinner size={14} /> | ||
| <span>Thinking…</span> | ||
| <Button |
There was a problem hiding this comment.
When a live non-pipeline session has no transcript groups, rendering takes the earlier Waiting for response… center-state branch, so this new Thinking-row Stop button is never mounted; because the composer no longer renders Stop while isLive, users cannot cancel a running session until at least one message group appears. This is especially problematic if startup hangs before the first transcript message is written.
Useful? React with 👍 / 👎.
| function handleInputKeydown(e: KeyboardEvent) { | ||
| if (e.key === 'Enter' && !e.shiftKey && !e.altKey) { | ||
| // Multiline input: plain Enter inserts a newline; Cmd/Ctrl+Enter sends. | ||
| if (e.key === 'Enter' && (e.metaKey || e.ctrlKey)) { |
There was a problem hiding this comment.
This makes Ctrl+Enter the documented send shortcut, but when the hashtag dropdown is open HashtagInput still consumes Enter whenever !shiftKey && !metaKey, so on Windows/Linux Ctrl+Enter selects the highlighted hashtag instead of reaching this handler. Messages with an open # suggestion therefore cannot be sent with the advertised shortcut unless the user first dismisses the dropdown or uses the button.
Useful? React with 👍 / 👎.
The hashtag dropdown's Enter guard excluded Shift and Meta but not Ctrl, so with the dropdown open, Ctrl+Enter selected the highlighted hashtag instead of falling through to the composer's send handler. Since Cmd/Ctrl+Enter is now the send chord, exclude ctrlKey too so both modifiers behave the same on every platform. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
The composer's pipeline stop area only rendered during the pipeline prelude (no transcript messages yet), so once steps started emitting messages the composer came back and the only stop control was the Thinking row, which lives in the scrollable transcript and doesn't render at all while the transcript is still empty. Key the bottom input area off the pipeline actually running (live session with a pipeline) instead of the prelude: while a pipeline runs, the composer (text field, model picker, attachment button) stays hidden and a Stop button remains available in the fixed bottom chrome, now with a text label matching the Thinking-row Stop. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
Send shortcuts had diverged across the three composers: the session chat pane sent on Cmd/Ctrl+Enter, NewSessionModal submitted on Cmd+Enter only (no Ctrl fallback for Windows/Linux), and the hidden SessionLauncher dev panel sent on plain Enter from a single-line input. Make multiline prompts work everywhere with one consistent chord: - NewSessionModal: accept Ctrl+Enter alongside Cmd+Enter to submit. - SessionLauncher: replace the single-line Input with an auto-resizing textarea (capped like the chat composer) where plain Enter inserts a newline and Cmd/Ctrl+Enter creates the session, removing the last "return means send" case. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Matt Toohey <contact@matttoohey.com>
1 participant
Summary
Changes
ChatComposer.svelte: dropped thecancelling/onStopprops and the live-state stop branch; the accent button now renders "Queue" when the session is live.SessionChatPane.svelte: keydown handler now requires Cmd/Ctrl+Enter to send; added the Stop button to the thinking row wired to the existing cancel handler.🤖 Generated with Claude Code