[codex] Fix relay WebSocket admission limits#1682
Open
jmecom wants to merge 2 commits into
Open
Conversation
jmecom
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets parser-level WebSocket frame/message caps on both the main relay door and the huddle audio door, and makes huddle audio upgrades consume the same global connection permit as normal relay sockets.
Before this change, an unauthenticated caller could open
/huddle/<random uuid>/audiosockets and hold them through the 5-second auth timeout without consumingBUZZ_MAX_CONNECTIONS. Both WebSocket doors also checked message size only after tungstenite had assembled the payload, so a caller could make the relay buffer oversized pre-auth messages before Buzz rejected them.The handler-level checks remain as defense in depth. Tested with
cargo test -p buzz-relay --lib,cargo clippy -p buzz-relay --all-targets -- -D warnings, and a local replay withBUZZ_MAX_CONNECTIONS=1.just cistill fails in unrelated desktop Tauri clippy warnings already present onorigin/main.