Fix desktop launch motion and reaction spacing#1717
Open
klopez4212 wants to merge 2 commits into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 420bd8d952
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
wait_for_stable_initial_window_geometry only accepted bounds when is_maximized() returned Ok(true). When the window-state plugin restores a normal (non-maximized) saved window, is_maximized() is false, so bounds stayed None forever, no stable state was detected, and the reveal waited the full poll budget (~1.9s) before timing out on every launch. Sample outer position/size regardless of maximized state and rely on consecutive identical bounds to detect that the async restore settled. Signed-off-by: klopez4212 <klopez4212@gmail.com> Co-authored-by: Fizz <8a675edd33677aa0389f6650d467b2041fb0df4ca820eacb009babb95e3715d4@sprout-oss.stage.blox.sqprod.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The launch movement came from asynchronous window restoration plus the transparent first webview frames exposing the previous app's controls.
Testing
pnpm --dir desktop checkcargo check --manifest-path desktop/src-tauri/Cargo.toml --no-default-features --features system-keyringpnpm exec playwright test --project=smoke tests/e2e/reaction-order.spec.ts(2 passed)