Skip to content

[codex] Add view activity label to agent popover #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
matbalez wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −8
Draft

[codex] Add view activity label to agent popover #1748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions desktop/src/features/channels/ui/BotActivityBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,9 @@ export function BotActivityComposerAction({
size="sm"
/>
<span className="min-w-0 flex-1 truncate">{agent.name}</span>
<span className="shrink-0 whitespace-nowrap text-xs font-medium opacity-80">
View activity
</span>
<Loader2 className="h-4 w-4 shrink-0 animate-spin text-muted-foreground/70" />
</button>
);
Expand Down
17 changes: 9 additions & 8 deletions desktop/tests/e2e/channels.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,15 +1068,16 @@ test("shows and clears activity indicators for active channel agents", async ({
}, TEST_IDENTITIES.alice.pubkey);

await expect(page.getByTestId("bot-activity-composer-trigger")).toBeVisible();
await page.getByTestId("bot-activity-composer-trigger").click();
await expect(
page.getByTestId(
`bot-activity-composer-item-${TEST_IDENTITIES.alice.pubkey}`,
),
).toBeVisible();
await page
.getByTestId(`bot-activity-composer-item-${TEST_IDENTITIES.alice.pubkey}`)
.click({ force: true });
page.getByTestId("bot-activity-composer-trigger"),
).not.toContainText("View activity");
await page.getByTestId("bot-activity-composer-trigger").click();
const aliceActivityItem = page.getByTestId(
`bot-activity-composer-item-${TEST_IDENTITIES.alice.pubkey}`,
);
await expect(aliceActivityItem).toBeVisible();
await expect(aliceActivityItem).toContainText("View activity");
await aliceActivityItem.click({ force: true });
await expect(page.getByTestId("agent-session-thread-panel")).toBeVisible();
await expect(page.getByTestId("agent-session-thread-panel")).toContainText(
"alice",
Expand Down
Loading