review: resolve package-relative material locators when matching diff paths#212
Merged
Merged
Conversation
…contract (#213) * corpus: audit backports, check cross-wiring, terminology sweeps * median: one authored home — headings contract, payload check, all templates stamp the floor * vessel-light: re-derive median onto the headings contract; docs get the ownership reframe
nahiyankhan
added a commit
that referenced
this pull request
Jul 9, 2026
…211) * skill: adapting-a-starter recipe — the seven-step transplant procedure * review: resolve package-relative material locators when matching diff paths (#212) * review: resolve package-relative material locators when matching diff paths * demo: drop stale parked-branch reference from eval artifacts gitignore * median: one authored home — model truth stamped at init, prunable by contract (#213) * corpus: audit backports, check cross-wiring, terminology sweeps * median: one authored home — headings contract, payload check, all templates stamp the floor * vessel-light: re-derive median onto the headings contract; docs get the ownership reframe
nahiyankhan
added a commit
that referenced
this pull request
Jul 9, 2026
* init: packed-payload mechanism — dist payloads, byte-capable template seam * template: skeleton rides packed files * init: --body vessel-light — install the full inhabited package * checks: packed-artifact body probes — fonts and checks survive pack * docs: body install in getting-started + cli-reference; minor changeset * skill: adapting-a-starter — the seven-step starter transplant recipe (#211) * skill: adapting-a-starter recipe — the seven-step transplant procedure * review: resolve package-relative material locators when matching diff paths (#212) * review: resolve package-relative material locators when matching diff paths * demo: drop stale parked-branch reference from eval artifacts gitignore * median: one authored home — model truth stamped at init, prunable by contract (#213) * corpus: audit backports, check cross-wiring, terminology sweeps * median: one authored home — headings contract, payload check, all templates stamp the floor * vessel-light: re-derive median onto the headings contract; docs get the ownership reframe
nahiyankhan
added a commit
that referenced
this pull request
Jul 9, 2026
…n floor (#209) * template: naked skeleton replaces steering default * checks: median-tells scaffold — live check pairing with anti-goal.median, deterministic floor, model tells * skill: migrate Morrow teaching shapes to authoring-scenarios * docs: skeleton starter in getting-started + cli-reference; minor changeset * ghost init --body: packed payloads + vessel-light body install (#210) * init: packed-payload mechanism — dist payloads, byte-capable template seam * template: skeleton rides packed files * init: --body vessel-light — install the full inhabited package * checks: packed-artifact body probes — fonts and checks survive pack * docs: body install in getting-started + cli-reference; minor changeset * skill: adapting-a-starter — the seven-step starter transplant recipe (#211) * skill: adapting-a-starter recipe — the seven-step transplant procedure * review: resolve package-relative material locators when matching diff paths (#212) * review: resolve package-relative material locators when matching diff paths * demo: drop stale parked-branch reference from eval artifacts gitignore * median: one authored home — model truth stamped at init, prunable by contract (#213) * corpus: audit backports, check cross-wiring, terminology sweeps * median: one authored home — headings contract, payload check, all templates stamp the floor * vessel-light: re-derive median onto the headings contract; docs get the ownership reframe
nahiyankhan
added a commit
that referenced
this pull request
Jul 9, 2026
…edian floor (#208) * materials: tokens audit — radius roles, hoist grammar-enumerated values * corpus: fork-axis re-author — grammar/signature/register/anti-goal * checks: relationship/value split — density.md retired, median-tells gains demoted rules, frequency thresholds, model-named tells * materials: regenerate refs — annotated, closed-set complete * docs: vessel-light README — fork-axis structure and ref-annotation curation * ghost init: naked skeleton default — grammar, unanswered dials, median floor (#209) * template: naked skeleton replaces steering default * checks: median-tells scaffold — live check pairing with anti-goal.median, deterministic floor, model tells * skill: migrate Morrow teaching shapes to authoring-scenarios * docs: skeleton starter in getting-started + cli-reference; minor changeset * ghost init --body: packed payloads + vessel-light body install (#210) * init: packed-payload mechanism — dist payloads, byte-capable template seam * template: skeleton rides packed files * init: --body vessel-light — install the full inhabited package * checks: packed-artifact body probes — fonts and checks survive pack * docs: body install in getting-started + cli-reference; minor changeset * skill: adapting-a-starter — the seven-step starter transplant recipe (#211) * skill: adapting-a-starter recipe — the seven-step transplant procedure * review: resolve package-relative material locators when matching diff paths (#212) * review: resolve package-relative material locators when matching diff paths * demo: drop stale parked-branch reference from eval artifacts gitignore * median: one authored home — model truth stamped at init, prunable by contract (#213) * corpus: audit backports, check cross-wiring, terminology sweeps * median: one authored home — headings contract, payload check, all templates stamp the floor * vessel-light: re-derive median onto the headings contract; docs get the ownership reframe
nahiyankhan
added a commit
that referenced
this pull request
Jul 9, 2026
…ng-eval harness (#207) * Add vendored vessel-react fingerprint: taste-floor nodes, materials wired to component sets, baseline hygiene checks * Rename packages/vessel to packages/vessel-react; workspace fingerprint id follows * Add vessel-light: Vessel's design language as a portable .ghost fingerprint for raw HTML/CSS agents * Add steering-eval: portable before/after evaluation harness for Ghost fingerprints; wire vessel-light demo as first consumer * Fix pilot findings: agent-browser set-viewport invocation, skip empty cells, brandTokens/pulledWords from tape * Run the full steering-eval matrix on vessel-light: 45 generations + dump-growth, screenshots, metrics, report * Park eval run artifacts on vessel-eval-artifacts branch; ignore demo/out on mainline * steering-eval: emit WebP screenshots (shoot to PNG, convert via cwebp, embed webp in report) * vessel-light: fork-axis re-authoring — grammar/signature/register + median floor (#208) * materials: tokens audit — radius roles, hoist grammar-enumerated values * corpus: fork-axis re-author — grammar/signature/register/anti-goal * checks: relationship/value split — density.md retired, median-tells gains demoted rules, frequency thresholds, model-named tells * materials: regenerate refs — annotated, closed-set complete * docs: vessel-light README — fork-axis structure and ref-annotation curation * ghost init: naked skeleton default — grammar, unanswered dials, median floor (#209) * template: naked skeleton replaces steering default * checks: median-tells scaffold — live check pairing with anti-goal.median, deterministic floor, model tells * skill: migrate Morrow teaching shapes to authoring-scenarios * docs: skeleton starter in getting-started + cli-reference; minor changeset * ghost init --body: packed payloads + vessel-light body install (#210) * init: packed-payload mechanism — dist payloads, byte-capable template seam * template: skeleton rides packed files * init: --body vessel-light — install the full inhabited package * checks: packed-artifact body probes — fonts and checks survive pack * docs: body install in getting-started + cli-reference; minor changeset * skill: adapting-a-starter — the seven-step starter transplant recipe (#211) * skill: adapting-a-starter recipe — the seven-step transplant procedure * review: resolve package-relative material locators when matching diff paths (#212) * review: resolve package-relative material locators when matching diff paths * demo: drop stale parked-branch reference from eval artifacts gitignore * median: one authored home — model truth stamped at init, prunable by contract (#213) * corpus: audit backports, check cross-wiring, terminology sweeps * median: one authored home — headings contract, payload check, all templates stamp the floor * vessel-light: re-derive median onto the headings contract; docs get the ownership reframe * build: root build and packed-package check produce the full ghost artifact Root pnpm build only ran tsc, so dist/init-payloads and dist/skill-bundle were missing in CI: the vessel-light body test failed and check-packed-package packed a tarball without payloads. Root build now chains the package-level build; check:packed-package builds its own complete artifact since the lint job never runs pnpm build. Signed-off-by: Nahiyan Khan <nahiyan@squareup.com> --------- Signed-off-by: Nahiyan Khan <nahiyan@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact:
ghost reviewnow correctly offers a fingerprint's value checks when the package lives below the repo root — previously they were silently dropped from the review packet.Problem: Found during #208's ref-regeneration acceptance test:
checks/values.mdwas never offered even though files listed in its referenced nodes'materialswere in the diff. Root cause:resolveReviewmatched raw locator text against diff paths. Git emits diff paths repo-relative (packages/vessel-light/.ghost/materials/tokens.css), but exact-path locators are package-relative (materials/tokens.css) — so every exact-path locator silently missed whenever the package sat below the repo root. Glob locators like**/*.cssmasked the bug by matching anything, which is why grammar-referencing checks were still offered and the drop went unnoticed.Solution: Match locators through
materialLocatorClaimsPath— the same ghost-core resolutionghost validatealready uses — which expands package-relative locators to their repo-relative form before matching.buildReviewPacketgains apackageDiroption; the review command threads the resolved package dir through.Stacked on #211 (base:
adapting-a-starter) — the review machinery this fixes only exists in the stack. Full merge order: #207 ← #208 ← #209 ← #210 ← #211 ← this.Validation:
nested/app/.ghostwith an exact-pathmaterials/tokens.csslocator + a check referencing the node → check offered asmatched. Verified the test fails without the fix (stash/rebuild/run: 1 failed) and passes with it.values(previously 4, values missing).pnpm check+pnpm test(133 passed, 1 skipped) via pre-commit.Changeset: added (
patch) — user-facing fix toghost reviewbehavior.Ghost Review: N/A — this fixes the review command itself; validated by its own packet output above.
File changes
packages/ghost/src/review/resolve.ts
resolveReviewgains aMaterialTransportOptionsparameter; locator matching switches from raw-textmatchesGlobtomaterialLocatorClaimsPath(package-relative expansion, same semantics as validate). Comment documents the failure shape.packages/ghost/src/review/review-packet.ts
BuildReviewPacketOptions.packageDir; builds transport options (git root + package dir + materials dir) and passes them through.packages/ghost/src/commands/review-command.ts
Threads
paths.packageDirinto the packet builder.packages/ghost/test/cli.test.ts
Regression test: nested package, exact-path locator, check offered as matched.
.changeset/review-locator-matching.md
patch.
Screenshots/Demos: N/A — CLI fix; the JSON packet diff above is the evidence.