Refocus fingerprints around covers and foundations#221
Merged
Conversation
* Close the Vessel Light material contract * Rename the evaluation harness to steering-control (#223) * Rename the evaluation harness to steering-control * Add a context selection control bench (#224) * Add a context selection control bench * Tighten context control semantics (#225) * Tighten context control semantics * Fix docs/code drift: GHOST_PACKAGE_DIR, goose install, legacy checks dir (#226) * Fix docs/code drift: GHOST_PACKAGE_DIR, goose install, legacy checks dir - Make every command (not just init/validate) respect GHOST_PACKAGE_DIR by centralizing the fallback in resolveFingerprintPackage(). Explicit --package still bypasses the stricter env-var path validation. - Add goose as a supported --agent in install/install.sh (curl installer), matching what ghost skill install --agent already supported. Fix the installer's stale file-list comment to match install/manifest.json. - Remove legacy pre-flat checks directory detection entirely from check-files.ts and node-files.ts; delete the now-obsolete tests for it. - Reconcile the 'reserved at the package root' docs (getting-started.mdx, fingerprint-authoring.mdx) to include materials/, matching the code and the other docs that already listed it. * Retire stale docs, dedupe READMEs, add troubleshooting guide (#227) - Retire docs/vessel-agent-safe-reference-system.md (Phase 0 migration plan, not durable architecture); fold its permanent invariants (North star, token contract, escape hatch policy) into packages/vessel-react/README.md. - Retire docs/agent-readable-brand-steering.md and its research-references.md appendix; most of it had already graduated into the shipped skill bundle in sharper form. Harvest the two gaps that hadn't graduated (bound/open pattern authoring, concept.* nodes) into packages/ghost/src/skill-bundle/references/capture.md. - Add docs/README.md stating the bar for what belongs in maintainer- facing docs/, so stale design docs don't reaccumulate. - Deduplicate packages/ghost/README.md against the root README: the root stays canonical (thesis, full model, repo layout), the package README becomes a lean npm-facing stub that links out. - Add apps/docs/src/content/docs/troubleshooting.mdx covering the failure modes with no doc today: empty gather, undeclared-kind warnings, review's exit 2, pull's unknown-id handling, stranded materials, stale CLI examples, and unmerged fingerprint edits. Cross-link it from Getting Started and CLI Reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: improvement
User Impact: Fingerprints always carry their essential brand context while exposing a simpler, description-led selection model.
Problem: Glossary posture split nodes into hidden, ordinary, and review-only classes while the starter mixed structural grammar with brand-specific answers. Essential stance also depended on agents remembering to pull an index node.
Solution: Replace posture with one flat menu, add a manifest-declared cover that gather always inlines, surface missing descriptions, and rebuild the starter around a brand cover, foundation chapters, contexts, and a cliche floor. The skill now teaches this model and includes a concrete-tier selection recipe.
Validation:
pnpm test: 170 passed, 1 skipped on the full stackpnpm check: passed on the full stackpnpm check:terminology: passedpnpm check:release-tarball: passedpnpm check:cli-manifest: passedChangeset: added for posture removal, cover/starter redesign, missing-description warnings, and the concrete-tier recipe.
Ghost Review:
ghost review: not run because this repository has no root fingerprint package after the entrance cleanupFile changes
.changeset/*: release notes for each public contract change.packages/ghost/src/ghost-core/*: removes posture metadata and adds manifest cover support.packages/ghost/src/commands/*: simplifies gather/pull/pulse, inlines covers, and reports description coverage.packages/ghost/src/review/*: treats material-backed nodes uniformly and renames unchecked coverage.packages/ghost/src/scan/*: validates covers and descriptions, and extracts package linting into its own module.packages/ghost/src/init-payloads/*: replaces the old grammar/signature skeleton with cover, foundations, contexts, and cliches.packages/ghost/src/skill-bundle/*: documents the cover-led model and concrete material tiers.packages/ghost/test/*: covers the revised CLI, linting, catalog, and review contracts.apps/docs/src/generated/cli-manifest.json: removes the retired--wildflag.install/manifest.json: updates installed skill references.packages/vessel-*/**/glossary.md: removes obsolete posture declarations.packages/vessel-light/.ghost/manifest.yml: declares the existing index as the cover.scripts/check-release-tarball.mjs: expects the renamed cliche payload.scripts/check-terminology.mjs: retires posture vocabulary.Screenshots/Demos: N/A