Tx evaluation by ginnun · Pull Request #378 · blockfrost/blockfrost-platform

ginnun · 2025-09-12T10:03:16Z

Resolves #306

Stacked on #537 - merge that one first.

Context

Implements tx evaluation APIs compatible with the Blockfrost.io version:

/utils/txs/evaluate
/utils/txs/evaluate/utxos

What is added

Two new endpoints with integration tests
bf-tx-evaluator crate providing native (Rust, via pallas-validate) and external (Haskell, via testgen-hs) evaluators
ChainConfigWatch in bf-node - a background task that watches the Cardano node and publishes protocol params + genesis config via tokio::sync::watch, refreshed only at epoch boundaries
Node helpers: ledger, utxo, chain_config_watch

What is changed

Pallas fork switched to blockfrost/pallas with pallas-validate (phase2 feature) for script evaluation
CBOR validation error messages improved (graceful fallback on pallas-hardano formatting failure)
Devshell picks up tools needed by the new native deps - m4 (for secp256k1-sys), make/awk/diffutils (for integration tests)
cardano-node trace silencing migrated to the newer API
CI: CARGO_PROFILE_DEV_DEBUG=0 on integration-test jobs to reduce disk pressure

What is scoped out (now in #537)

testgen-hs subprocess handling extracted from crates/node/src/cbor/ into dedicated bf-testgen and bf-error-decoder crates
testgen-hs version bump to 10.6.3.1 and release binary downloads switched to blockfrost/testgen-hs
build_utils target detection helpers factored out

cloudflare-workers-and-pages · 2025-09-12T10:54:52Z

Deploying blockfrost-platform with Cloudflare Pages

Latest commit:	`3bd7bfd`
Status:	✅ Deploy successful!
Preview URL:	https://e1927172.blockfrost-platform.pages.dev
Branch Preview URL:	https://feat-tx-evaluation-rebased.blockfrost-platform.pages.dev

View logs

michalrus

Hey, I started reviewing, but then noticed that it's a draft! Left a few comments either way :)

michalrus · 2026-01-20T15:33:53Z

Maybe let's have a simpler merge commit for the current conflicts? 🥺 Unless you're using git-rerere.

michalrus · 2026-02-12T11:15:20Z

I've just merged main into this PR in cd2794a — I hope correctly… … 🫣

michalrus

I pushed another merge with main, because there were some more conflicts to resolve. I hope I did that correctly!

Now I see that cargo test tests are failing:

❯ cargo nextest run --workspace --lib --verbose

…

     Summary [  76.650s] 650 tests run: 195 passed, 455 failed, 0 skipped

Stuff like:

        FAIL [   1.058s] blockfrost-platform-error-decoder external::tests::test_cbor_0001_ConwayTreasuryValueMismatch_Coin_Coin

Or:

        FAIL [   1.086s] blockfrost-platform-error-decoder tests::specific::test_cbor_0013_ConwayWdrlNotDelegatedToDRep_KeyHash_KeyHash

michalrus · 2026-02-12T15:28:32Z

Maybe the tests are failing because my commits updated testgen-hs to 10.4.1.2 also in the devshell. And it's the one against which the old CBOR tests are being run. 🤔

ginnun · 2026-02-20T23:34:23Z

Everything is working related to this PR. The CI failure is caused by updated ledger codebase coming from the testgen-hs binary

michalrus · 2026-02-23T09:23:52Z

The CI failure is caused by updated ledger codebase coming from the testgen-hs binary

So what do you suggest to be a solution here?

Maybe update testgen-hs in a separate PR, to not mix them, and fix it there? And park this one until we're again matching the Haskell trasaction submission errors?

(I think we shouldn’t be merging "red" ❌ PRs.)

michalrus · 2026-02-23T09:47:58Z

@ginnun wait, but why did I get the same error in:

I don’t have your changes (the updated testgen-hs).

So the integration tests would also fail on main now? Perhaps due to devops updating cardano-node in the "legacy" Blockfrost API?

michalrus · 2026-02-23T09:50:53Z

Look here:

Deploying cardano-node version v10.6.2 to dev hosts

on 2026-02-19T02:55:30,167769000+00:00.

ginnun · 2026-02-23T10:02:23Z

So what do you suggest to be a solution here?

The plan is to fix/update the code for pallas/hardano. Until than, we can disable that specific test since it will fail for every branch. What do you say @michalrus ?

michalrus · 2026-02-23T10:18:55Z

The plan is to fix/update the code for pallas/hardano.

Great! Here's a tracking issue for this new work:

Platform integration tests failing on recent branches #459

michalrus · 2026-02-23T10:19:28Z

Until than, we can disable that specific test since it will fail for every branch. What do you say @michalrus ?

I suppose… Hmm, WDYT, @vladimirvolek?

This temporary fix is in:

chore: temporarily ignore test_route_submit_error (submission errors changed) #460

Copilot

Pull request overview

Copilot reviewed 70 out of 72 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

src/server.rs:2

This file is currently empty and the workspace root has no [package], so it is unused. Keeping an empty src/server.rs in the repository is confusing and may suggest there is a root crate/module. Please remove it if it’s accidental.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

michalrus

Note to self for when this PR is close to a merge:

Let's have a small PR to move testgen-hs handling on main in accordance to what the tx-eval PR did – for better view of conflicts and what really changed

(requesting changes so that it's not lost)

ginnun · 2026-04-17T09:25:04Z

Note to self for when this PR is close to a merge:

Let's have a small PR to move testgen-hs handling on main in accordance to what the tx-eval PR did – for better view of conflicts and what really changed

(requesting changes so that it's not lost)

@michalrus This is in the making.

- chore: add devshell tools and CI tweaks for tx evaluation - chore: update workspace deps for tx evaluation - feat(common): add lazy chain config loader and helpers - fix(node): improve CBOR validation error messages - feat(node): add chain config, ledger, and utxo helpers - feat: add bf-tx-evaluator crate with native and external evaluators - feat(platform): add /utils/txs/evaluate endpoints - test: add coverage for tx evaluate endpoints

vercel · 2026-04-29T06:32:42Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
blockfrost-platform-docs	Ready	Preview, Comment	May 12, 2026 0:31am
blockfrost-platform-docs-next	Ready	Preview, Comment	May 12, 2026 0:31am

ginnun · 2026-04-29T09:04:03Z

Failing tests are unrelated to this PR.

For evaluate failure, please see blockfrost/blockfrost-tests#73

…based

michalrus

A couple questions – the most important one is about the mempool omission:

michalrus · 2026-05-14T08:22:56Z

-pallas-network = { git = "https://github.com/txpipe/pallas.git", rev = "ed422bc0d5a09f77617d4882dd4c71089a8bcdb2" }
-pallas-primitives = { git = "https://github.com/txpipe/pallas.git", rev = "ed422bc0d5a09f77617d4882dd4c71089a8bcdb2" }
-pallas-traverse = { git = "https://github.com/txpipe/pallas.git", rev = "ed422bc0d5a09f77617d4882dd4c71089a8bcdb2" }
+pallas-addresses = { git = "https://github.com/blockfrost/pallas.git", rev = "cfa0c633640f5989e44f50ed27efc38992f9ed0d" }


There has been one more commit since then in your PR – txpipe/pallas@9a83c74

michalrus · 2026-05-14T08:28:02Z

+
+        utxos.insert(TxoRef::from(&multi_era_in), EraCbor::from(multi_era_out));
+    }
+    let mut node = node_pool.get().await?;


I don't see this comment here. Maybe more like FIXME, not TODO? 🫣

michalrus · 2026-05-14T09:19:50Z

@@ -37,5 +37,7 @@
  "/epochs/latest/parameters",
  "/genesis",
  "/addresses/{address}/transactions",
-  "/addresses/{address}/utxos"
+  "/addresses/{address}/utxos",
+  "/utils/txs/evaluate",


I should underline, we don't have mempool integration yet (Ogmois does use mempool + chain)

So the implementation is not equivalent, even though we're deferring to Haskell code?

Shouldn’t we add it before releasing? 👀

How hard is it?

And why isn’t it caught by blockfrost-tests?

michalrus · 2026-05-14T09:58:06Z

+                Err(e) => {
+                    tracing::warn!(
+                        "ChainConfigWatch: failed to refresh chain config: {e}. Retrying in {}s.",
+                        RETRY_INTERVAL.as_secs()
+                    );
+                    tokio::select! {
+                        () = time::sleep(RETRY_INTERVAL) => {},
+                        () = tx.closed() => {
+                            tracing::info!("ChainConfigWatch: stopping monitor");
+                            return;
+                        },
+                    }
+                },


So between the epoch boundary and successful refresh, stale protocol params would be used by eval? And the refresh might only practically fail if a node is down?

@michalrus Yes that is correct. Alternatively we can fail (or wait) evaluate calls on epoch boundary but that might be fragile. Another (bad) option is to never cache those values.

michalrus · 2026-05-14T10:01:26Z

+        let (tx, rx) = watch::channel(None);
+
+        tokio::spawn(async move {
+            monitor_loop(node_pool, tx).await;


Can this panic? 👀 It seems rather crucial for correct eval results, and we wouldn't restart it then, no?

michalrus · 2026-05-14T11:21:28Z

+) -> Result<MultiEraProtocolParameters, BlockfrostError> {
+    // Create a Conway protocol parameters struct from the ProtocolParam and GenesisConfig
+    let conway_pp: ConwayProtParams = ConwayProtParams {
+        minfee_a: pp.minfee_a.required("minfee_a")? as u32,


Why are they u64 in CurrentProtocolParam, but u32 in ConwayProtParams? Are these multiple conversions always safe?

michalrus · 2026-05-14T11:22:58Z

+                let tx_id = utxo
+                    .get("transaction")
+                    .and_then(|transaction| transaction.get("id"))
+                    .unwrap_or(&Value::Null);


Is the null okay here, or should we error?

michalrus · 2026-05-14T11:24:06Z

+- Native is based on `pallas-validate`.
+- External is using `ledger` codebase via `testgen` Haskell binary.
+
+`native` produces different evaluation results when compared to `external` at the moment. Knowing that `external` depends on the ledger codebase, we can consider `external` results accurate.


But we don’t implement the mempool part there? 👀

Yes, no mempool handling. Haskell part doesn't fetch any data from any source. By design, it's the Rust parts that needs to fetch any data and pass it to forward.

michalrus · 2026-05-14T11:25:37Z

+    if let Some(first_result) = results.first() {
+        matches!(first_result, TxEvalResultV6::Success(_))
+    } else {
+        true


Can you explain this true here? Why are empty results a success?

michalrus · 2026-05-14T11:28:25Z

+#[derive(Serialize, Deserialize, Debug)]
+#[serde(untagged)]
+pub enum EvaluationError {
+    Evaluation(serde_json::Value),
+    Deserialization(DeserializationErrorData),
+}


Since this is #[serde(untagged)], and the first variant is arbitrary JSON, the deserializer would never reach the second variant 🤔 Do we ever use the deserializer? If not, maybe let's drop it?

ginnun marked this pull request as draft September 12, 2025 10:03

michalrus reviewed Sep 16, 2025

View reviewed changes

Comment thread nix/internal/unix.nix Outdated

Comment thread nix/internal/unix.nix Outdated

Comment thread src/api/utils/txs/evaluate/model.rs Outdated

Comment thread crates/testgen/src/testgen.rs Outdated

Comment thread crates/node/src/cbor/fallback_decoder.rs Outdated

michalrus mentioned this pull request Sep 16, 2025

Implement tx submit evaluation via pallas & haskell #322

Closed

ginnun force-pushed the feat/tx-evaluation-rebased branch 3 times, most recently from c702f03 to a53a53c Compare September 22, 2025 12:06

ginnun changed the title ~~Feat/tx evaluation rebased~~ Tx evaluation Sep 23, 2025

ginnun force-pushed the feat/tx-evaluation-rebased branch 2 times, most recently from 3bcc5c5 to e67b1a9 Compare October 10, 2025 11:35

michalrus linked an issue Nov 17, 2025 that may be closed by this pull request

Add POST /utils/txs/evaluate – how many execution units for a transaction #306

Open

ginnun marked this pull request as ready for review December 15, 2025 10:02

ginnun force-pushed the feat/tx-evaluation-rebased branch from 6980be7 to f269525 Compare January 16, 2026 09:32

michalrus reviewed Feb 12, 2026

View reviewed changes

michalrus mentioned this pull request Feb 12, 2026

Add POST /utils/txs/evaluate – how many execution units for a transaction #306

Open

ginnun force-pushed the feat/tx-evaluation-rebased branch 2 times, most recently from a4a277d to dde536f Compare February 27, 2026 15:03

ginnun commented Feb 27, 2026

View reviewed changes

Comment thread nix/internal/unix.nix Outdated

michalrus requested changes Mar 2, 2026

View reviewed changes

Comment thread nix/internal/unix.nix Outdated

ginnun force-pushed the feat/tx-evaluation-rebased branch from 6642500 to 1db6c61 Compare March 2, 2026 15:02

ginnun requested a review from Copilot April 10, 2026 16:52

Copilot started reviewing on behalf of ginnun April 10, 2026 16:52 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Comment thread crates/tx_evaluator/src/wrapper.rs Outdated

Comment thread crates/tx_evaluator/src/ogmios5_response.rs

Comment thread crates/node/src/chain_config_watch.rs

Comment thread crates/tx_evaluator/src/external.rs

ginnun mentioned this pull request Apr 13, 2026

Add v6 evaluate tests to blockfrost-tests blockfrost/blockfrost-tests#67

Open

ginnun marked this pull request as draft April 13, 2026 09:05

michalrus requested changes Apr 14, 2026

View reviewed changes

ginnun marked this pull request as ready for review April 16, 2026 14:55

ginnun requested a review from michalrus April 16, 2026 14:55

ginnun mentioned this pull request Apr 17, 2026

Extract testgen-hs handling into dedicated crates #537

Merged

ginnun force-pushed the feat/tx-evaluation-rebased branch from aca4175 to 3b95456 Compare April 17, 2026 15:31

ginnun changed the base branch from main to refactor/testgen-hs-handling April 17, 2026 15:36

ginnun force-pushed the refactor/testgen-hs-handling branch from b625eed to 75aee91 Compare April 28, 2026 10:58

ginnun force-pushed the feat/tx-evaluation-rebased branch from 3b95456 to b02c4a6 Compare April 29, 2026 06:32

vercel Bot deployed to Preview – blockfrost-platform-docs-next April 29, 2026 06:33 View deployment

vercel Bot deployed to Preview – blockfrost-platform-docs April 29, 2026 06:33 View deployment

chore: bump blockfrost-tests flake input

59ea38d

vercel Bot deployed to Preview – blockfrost-platform-docs-next May 4, 2026 08:27 View deployment

vercel Bot deployed to Preview – blockfrost-platform-docs May 4, 2026 08:27 View deployment

vercel Bot deployed to Preview – blockfrost-platform-docs May 12, 2026 08:39 View deployment

vercel Bot deployed to Preview – blockfrost-platform-docs-next May 12, 2026 08:39 View deployment

Base automatically changed from refactor/testgen-hs-handling to main May 12, 2026 11:58

Merge remote-tracking branch 'origin/main' into feat/tx-evaluation-re…

3bd7bfd

…based

ginnun force-pushed the feat/tx-evaluation-rebased branch from 9d6a5ad to 3bd7bfd Compare May 12, 2026 12:30

vercel Bot deployed to Preview – blockfrost-platform-docs-next May 12, 2026 12:31 View deployment

vercel Bot deployed to Preview – blockfrost-platform-docs May 12, 2026 12:31 View deployment

michalrus reviewed May 14, 2026

View reviewed changes

Conversation

ginnun commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

What is added

What is changed

What is scoped out (now in #537)

Uh oh!

cloudflare-workers-and-pages Bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying blockfrost-platform with Cloudflare Pages

Uh oh!

michalrus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michalrus commented Jan 20, 2026

Uh oh!

michalrus commented Feb 12, 2026

Uh oh!

michalrus left a comment

Choose a reason for hiding this comment

Uh oh!

michalrus commented Feb 12, 2026

Uh oh!

ginnun commented Feb 20, 2026

Uh oh!

michalrus commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michalrus commented Feb 23, 2026

Uh oh!

michalrus commented Feb 23, 2026

Uh oh!

ginnun commented Feb 23, 2026

Uh oh!

michalrus commented Feb 23, 2026

Uh oh!

michalrus commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michalrus left a comment

Choose a reason for hiding this comment

Uh oh!

ginnun commented Apr 17, 2026

Uh oh!

vercel Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ginnun commented Apr 29, 2026

Uh oh!

michalrus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ginnun commented Sep 12, 2025 •

edited

Loading

cloudflare-workers-and-pages Bot commented Sep 12, 2025 •

edited

Loading

michalrus commented Feb 23, 2026 •

edited

Loading

michalrus commented Feb 23, 2026 •

edited

Loading

vercel Bot commented Apr 29, 2026 •

edited

Loading