Token page: prime address query, split loading states, and skip JSON parse on API errors - #3623
Merged
Merged
Conversation
- add address query to primed list - split the loading state of index tab so for slow address request it will show partial data from main token query - fix bug when server fetched data contains error payload (not the real data)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up improvements for the token page load experience:
core:addressrequest alongside the token and counters so the address data can arrive with SSR.fetchApiso non-OK responses are not parsed as JSON and returned as if they were successful data (avoids treating an error payload as real API data on the server).Environment variables
None
Minimum API version
None
Breaking or incompatible changes
None
Additional information
—
Made with Cursor