Fix cross-chain In/Out tag always showing "In" on multichain instances - #3624
Merged
Conversation
- Construct the tag only based on recipient or/and sender hash. - Introduce the "Self" variant for the tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3608
On multichain instances the cross-chain In/Out tag always showed In, because direction required
config.chain.idto match the source chain — and that id is unset when there is no single current chain.Direction is now derived only from whether the page address is the sender and/or recipient. Adds a Self tag when both sides are the page address. Shared logic lives in
CrossChainFromToTagTxand is used by the cross-chain transfers and messages list/table rows.Environment variables
None
Minimum API version
None
Breaking or incompatible changes
None
Additional information
None
Made with Cursor