Skip to content

CI: use native clang-format#72

Merged
willhoy merged 4 commits intobloomberg:mainfrom
678098:678098-patch-1
Mar 16, 2026
Merged

CI: use native clang-format#72
willhoy merged 4 commits intobloomberg:mainfrom
678098:678098-patch-1

Conversation

@678098
Copy link
Contributor

@678098 678098 commented Mar 12, 2026

Remove dependency from a third-party clang-format image.
Reduce formatter check time from ~1m30s to a few seconds.
Also print formatting errors in CI logs.
Use explicit ubuntu version tag.

Before (main)

  • 1m30s
  • No instructions what is wrong and how to fix it
Screenshot 2026-03-12 at 16 12 35

After (this PR)

  • 6 seconds
  • Actual diff that can be applied as a git patch, or applied manually
  • No extra third party dependency
Screenshot 2026-03-12 at 14 53 01

Remove dependency from a third-party clang-format image.
Reduce formatter check time from ~2 minutes to a few seconds.
Also print formatting errors in CI logs.

Signed-off-by: Evgenii Malygin <emalygin@bloomberg.net>
@678098
Copy link
Contributor Author

678098 commented Mar 12, 2026

Similar PR:
bloomberg/blazingmq#223

678098 added 2 commits March 12, 2026 14:51
Signed-off-by: Evgenii Malygin <emalygin@bloomberg.net>
Signed-off-by: Evgenii Malygin <emalygin@bloomberg.net>
@willhoy willhoy enabled auto-merge (squash) March 12, 2026 20:45
@willhoy willhoy merged commit 42dc02b into bloomberg:main Mar 16, 2026
4 checks passed
@678098 678098 deleted the 678098-patch-1 branch March 16, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants