Bumped xcodeproj version to support PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet#154
Bumped xcodeproj version to support PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSet#154JanC wants to merge 2 commits intobloomberg:mainfrom
Conversation
|
Thank you @JanC for the PR, very much appreciated! It looks like the DCO check is failing, would you mind signing your commits? |
| throw ComparatorError.generic(error.description) | ||
| } catch { | ||
| throw ComparatorError.generic("Encountered unknown error while loading XcodeProj at \(path.string)") | ||
| throw ComparatorError.generic("Encountered unknown error while loading XcodeProj at \(path.string): \(error)") |
There was a problem hiding this comment.
Perhaps we could change the ':' to a '.' here. Breaking this into two sentences makes the error output feel more like natural language and keeps it consistent with our other error message formats.
|
@JanC, our CI requires all the commits to be signed. Please follow the DCO instruction https://github.com/bloomberg/xcdiff/pull/154/checks?check_run_id=62382920209. Thank you and sorry for all the troubles. |
|
hey, yep I noticed, sorry for the delay. I'll fix it today EDIT: fixed :) |
JanC
force-pushed
the
fix-xcode-26
branch
6 times, most recently
from
a6387ef to
ade5e8f
Compare
…ldPhaseMembershipExceptionSet Signed-off-by: Jan Chaloupecky <jan.chaloupecky@gmail.com>
Signed-off-by: Jan Chaloupecky <jan.chaloupecky@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
- Coverage 97.05% 96.84% -0.21%
==========================================
Files 52 57 +5
Lines 2986 2567 -419
==========================================
- Hits 2898 2486 -412
+ Misses 88 81 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
hey,
small PR to support the xcode projects with the
PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSetDescribe your changes
PBXFileSystemSynchronizedGroupBuildPhaseMembershipExceptionSettuist/XcodeProj#894Testing performed
Additional context
I the current master, I was getting the error
I debugged in the sources a found out it's becase of an unspupported xcode element.
I added a the error to the log message: