Skip to content

Lukasz Busk - BEM#58

Open
Velsu wants to merge 3 commits into
bloominstituteoftechnology:masterfrom
Velsu:master
Open

Lukasz Busk - BEM#58
Velsu wants to merge 3 commits into
bloominstituteoftechnology:masterfrom
Velsu:master

Conversation

@Velsu

@Velsu Velsu commented Mar 28, 2018

Copy link
Copy Markdown

No description provided.

@kiachoi kiachoi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did a very nice job on this project Lukasz! You should be proud. 💯 I am always so impressed by how much dedication you put into understanding what you are coding! Thank you for always bringing in jokes to our group meetings and the honest feedback!

Comment thread index.html
</p>
</div>
<div class="boxes__rightBox">
<h3 class="rightBox__headline">Placeholder</h3>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also write this another way as boxes__rightBox--headline. This is just for organization. The standard is that if you are going to nest it will look something like item1__item2--item3. The reason why I would recommend you adding the boxes to the front is for clarification when you do your CSS or DOM. You will be able to clearly see where that rightBox__headline is from!

@@ -0,0 +1,17 @@
let dropdown = document.querySelector(".header__dropdown");

class Dropdown {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this dropdown! I hope Dan's solution along with the lecture helped you understand this part. Although dropdown itself is not so important, it is a neat thing to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants