Devon Bacon - Components - BEM#62
Open
devbacon wants to merge 18 commits into
Open
Conversation
…oject requirements
BonnW
approved these changes
Mar 29, 2018
BonnW
left a comment
BonnW
left a comment
There was a problem hiding this comment.
Hey Devon!
Great work on the project. You've definitely got a strong understanding of the content. I especially love the all of the reps you're getting since you're helping others as well as going above and beyond on your own.
The only comment I have for you is one extremely minor styling issue. In your styles.css your body tag is indented further than everything else.
It's important to try your best and stay consistent throughout the entirety of your code.
However, again, this is a VERY small issue. Otherwise, everything is perfect. Fantastic job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.