Tylar Pierson#66
Open
tylarpierson wants to merge 13 commits into
Open
Conversation
kiachoi
approved these changes
Apr 2, 2018
kiachoi
left a comment
kiachoi
left a comment
There was a problem hiding this comment.
Great job Tylar! Even you work before Dan's solution. Love all of your commits and team work. Thank you for all your hard work! 🚀
| @@ -0,0 +1,35 @@ | |||
| // function myFunction() { | |||
| // document.getElementById('myDropdown').classList.toggle('show') | |||
There was a problem hiding this comment.
Nice thought process here! I would have also probably used the toggle method as well.
There was a problem hiding this comment.
Also, thank you for commenting out your prior work! I love seeing you progress and make changes. 🔥
| </div> | ||
| <div class="Box"> | ||
| <div class="Box__header"> | ||
| <h3 class="Box__headerHeadline">Placeholder</h2> |
There was a problem hiding this comment.
You can make thing look something like Box__header--Headline. Just a suggestion but if you will have anything nested, the third element will usually come after --.
Item1__Item2--Item3--Item4 etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.