Ilqar Ilyasov - iOS2 - Poll Project#6
Open
ilqarilyasov wants to merge 13 commits intobloominstituteoftechnology:masterfrom
Open
Ilqar Ilyasov - iOS2 - Poll Project#6ilqarilyasov wants to merge 13 commits intobloominstituteoftechnology:masterfrom
ilqarilyasov wants to merge 13 commits intobloominstituteoftechnology:masterfrom
Conversation
…operty which holds all the votes and a Vote creating function.
…so their components.
…. Set the class to the related controller and gave the resuidentifier name to the cell on the storyboard.
…dded 2 container view and 2 storyboard referance. Gave identifier to each embed segue and tied to related storyboards. Added missing constraints.
…ances and PollingTabBarController.swift file.
|
Ilqar... Outstanding work! Great organization in your project, clean code, no gaps in between methods and/or variables, and committed quite a bit. I don't really have anything to critique you on, except for maybe suggesting you doing the extra credit steps (assuming you have extra time to spare). But other than that, good job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lpuentes19 Hey Luis. You can check it out. It's working