Open
Conversation
added 7 commits
May 1, 2019 12:43
…ryptexViewController.
…a new Cryptex. I'd also like to make sure it doesn't give you the same one twice.
|
Dan, let me start off by saying I love how visually appealing your codebase is. Your use of Marks makes it easy for me to navigate your file and get to the exact section of your code I need. Your implementation of hasMatchingPassword() is clear and easy to follow. Shorter than the solution code Lambda provides -- a big plus! I'm trying to find something to criticize, but you're making it difficult. You're following MVC and following "Swifty code." I'd recommend just trying to shoot for one, if not all Stretch Goals for any future projects, time permitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mosesrobinson