Robert/wasm consensus ga readiness 51ed evaluation by robert-matusewicz · Pull Request #22 · bluecontract/blue-quickjs

robert-matusewicz · 2026-04-24T06:34:36Z

Test PR

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

…lder Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

- add public package and workflow drift tests - unit-test release readiness freshness checks - extend QuickJS patch manifest integrity tests - add CLI integration coverage for Host.v2 ABI builds and failures - wire workload and release evidence test scripts

Add a critical coverage script for runtime, bundler, builder, ABI, CLI, and ecosystem certifier projects, with 40% thresholds across lines, branches, functions, and statements. Run the coverage gate in CI, upload coverage artifacts, and document it in the release checklist. Also add gas spec renderer test coverage and make the gas schedule renderer importable while preserving CLI behavior.

Narrow ecosystem-certifier coverage to the shared implementation modules covered by its node tests, excluding entrypoints, browser code, fixtures, host helpers, and type-only files from the initial critical threshold. Exclude CLI barrel/bin entrypoints from coverage and add explain-error mapping cases to lift branch coverage over the critical gate.

Exclude quickjs-runtime test helpers from the production TypeScript build and remove test-only project references from tsconfig.lib.json. Keep src/test helpers available through the spec tsconfig, teach the project reference checker to ignore test-only files/folders, and add regression coverage for both ignored test imports and enforced production imports. Add public package tarball hygiene checks for dist/test artifacts, emitted spec/test files, and emitted vitest references.

kgruszka · 2026-05-04T09:59:18Z

@codex review

kgruszka · 2026-05-04T10:30:58Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6034506796

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

kgruszka · 2026-05-04T10:36:38Z

@codex review

chatgpt-codex-connector · 2026-05-04T10:44:44Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 634ecb9074

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 61cdf22a70

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

blue-quickjs/libs/quickjs-runtime/src/lib/deterministic-init.ts

Lines 287 to 295 in 4c13cad

    
           if (typeof value === 'number') { 
        
             if (!Number.isFinite(value)) { 
        
               throw new Error('gasLimit must be finite'); 
        
             } 
        
             if (value < 0) { 
        
               throw new Error('gasLimit must be non-negative'); 
        
             } 
        
             return BigInt(value); 
        
           }

Enforce uint64 upper bound on numeric gas limits

normalizeGasLimit validates the uint64 upper bound only for bigint inputs, but the number branch converts directly with BigInt(value) and returns without a max check. When embedders call evaluate() (or setGasLimit) with a large JavaScript number above 2^64-1, this can pass through as an out-of-range i64 and be truncated/wrapped by the wasm boundary instead of being rejected, causing executions to run with an unintended gas limit.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b8f3488afc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-04T14:30:39Z

+  if (node.type === 'MemberExpression') {
+    return getCallTargetRootIdentifier(
+      asNode((node as { object?: unknown }).object),
+    );


Resolve forbidden API from member chains correctly

scanCompatibility now derives the call target via getCallTargetRootIdentifier, but for chained globals it returns the outer object (globalThis) instead of the forbidden API identifier (WebAssembly, Atomics, Date, etc.). As a result, calls like globalThis.WebAssembly.instantiate(...) or globalThis.Date.now() are not flagged and can incorrectly pass compatibility checks, deferring deterministic-profile failures to runtime instead of failing certification at build time.

Useful? React with 👍 / 👎.

cursoragent and others added 30 commits March 15, 2026 00:11

clarify raw script semantics and classify surface mismatches

630b065

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

add deterministic bundler library and compatibility scanning

07fecf8

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

add profile-gated regexp compatibility through runtime init

686b2fc

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

add chess.js bundled reuse fixtures and parity tests

3692941

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

fix quickjs submodule pin and docs origin

95c5b19

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

add P13 architecture docs and feature-flag quickjs pin

30a6237

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

add module-pack builder API and v2 artifact validation scaffolding

86057a2

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

introduce deterministic-builder package and align P14 docs

82f0a5e

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

emit compatibility reports and program artifacts from module-pack bui…

da7b9df

…lder Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

accept ProgramArtifact.v2 script mode in evaluate pipeline

17e3801

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

add shared execution profile registry and wire runtime checks

a1563c6

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

add module-pack runtime execution path for ProgramArtifact v2

737e4fa

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

add module-pack smoke parity fixtures for node and browser

221b3f7

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

add native module-pack fixture assertions with gas and tape

12cf629

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

migrate compatibility fixtures to compat-general profile

5d9610f

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

enable deterministic promise job draining for compat profiles

224c8e9

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

add async promise and queueMicrotask parity fixtures

f3d937b

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

enable compat-profile console shim through host emit

b18c858

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

enable compat-profile stable sort with parity fixtures

92284b6

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

add dv2 byte-string codec foundation APIs

0540599

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

add quickjs dv2 codec entrypoints and plan updates

9d6f120

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

wire Host.v2 DV2 bytes across runtime boundaries

4dabc2b

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

add binary library compatibility fixtures and parity checks

44e024a

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

add initial blue-quickjs CLI command suite

4645fa4

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

Add source-map remapping and richer CLI diagnostics

4554492

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

Add parity report runner for cross-environment validation

c5e2736

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

Extend parity report with gas-delta aware compare modes

e20bf7e

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

Gate native harness tests with parity report snapshots

73b5e11

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

Add gas delta baseline enforcement for parity report

8c3abf2

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

Support strict parity checks with gas delta baseline normalization

929e2e2

Co-authored-by: piotr-blue <piotr-blue@users.noreply.github.com>

robert-matusewicz added 2 commits April 30, 2026 14:37

Fix failing test

2c510cc

robert-matusewicz force-pushed the robert/wasm-consensus-ga-readiness-51ed-evaluation branch from 6e24682 to 8caee1d Compare April 30, 2026 19:16

Fix linter issues

c50255b

robert-matusewicz force-pushed the robert/wasm-consensus-ga-readiness-51ed-evaluation branch from 8caee1d to c50255b Compare April 30, 2026 19:20

robert-matusewicz added 2 commits May 1, 2026 11:19

Remove blank line at docs/gas-schedule.md

3266948

robert-matusewicz force-pushed the robert/wasm-consensus-ga-readiness-51ed-evaluation branch from 18bd5a2 to 2e5dfea Compare May 1, 2026 16:18

robert-matusewicz force-pushed the robert/wasm-consensus-ga-readiness-51ed-evaluation branch from 2e5dfea to 450c39e Compare May 2, 2026 06:35

robert-matusewicz added 2 commits May 2, 2026 14:25

refresh release readiness evidence

6034506

robert-matusewicz requested review from kgruszka and mjwebblue and removed request for mjwebblue May 4, 2026 07:40

chatgpt-codex-connector Bot reviewed May 4, 2026

View reviewed changes

Comment thread libs/deterministic-bundler/src/lib/deterministic-bundler.ts

Fix deterministic scanner for node builtin named re-exports

634ecb9

chatgpt-codex-connector Bot reviewed May 4, 2026

View reviewed changes

Comment thread libs/deterministic-bundler/src/lib/deterministic-bundler.ts

Comment thread tools/blue-quickjs-cli/src/lib/cli.ts Outdated

Reject malformed CLI gas-version values

61cdf22

chatgpt-codex-connector Bot reviewed May 4, 2026

View reviewed changes

Comment thread libs/deterministic-bundler/src/lib/deterministic-bundler.ts Outdated

Comment thread libs/deterministic-bundler/src/lib/deterministic-bundler.ts

fix deterministic bundler member-call compatibility scan

4c13cad

chatgpt-codex-connector Bot reviewed May 4, 2026

View reviewed changes

robert-matusewicz added 3 commits May 4, 2026 16:03

blue-quickjs/libs/quickjs-runtime/src/lib/deterministic-init.ts

a8b01a8

validate deterministic bundler execution profiles at build time

0c7328e

scan tree-shaken bundle output for compatibility

b8f3488

chatgpt-codex-connector Bot reviewed May 4, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Robert/wasm consensus ga readiness 51ed evaluation#22

Robert/wasm consensus ga readiness 51ed evaluation#22
robert-matusewicz wants to merge 160 commits intomainfrom
robert/wasm-consensus-ga-readiness-51ed-evaluation

robert-matusewicz commented Apr 24, 2026

Uh oh!

kgruszka commented May 4, 2026

Uh oh!

kgruszka commented May 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

kgruszka commented May 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	if (typeof value === 'number') {
	if (!Number.isFinite(value)) {
	throw new Error('gasLimit must be finite');
	}
	if (value < 0) {
	throw new Error('gasLimit must be non-negative');
	}
	return BigInt(value);
	}

Conversation

robert-matusewicz commented Apr 24, 2026

Uh oh!

kgruszka commented May 4, 2026

Uh oh!

kgruszka commented May 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

kgruszka commented May 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants