Skip to content

No SDK changes required: internal server-side trait serializer cleanup#33

Closed
Copilot wants to merge 1 commit intomainfrom
copilot/update-python-sdk-blueink-core
Closed

No SDK changes required: internal server-side trait serializer cleanup#33
Copilot wants to merge 1 commit intomainfrom
copilot/update-python-sdk-blueink-core

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 4, 2026

The blueink-core production change (7e494c9) removed the append_legacy parameter from the internal GroupTraits.from_account() call in AccountV2Serializer — a pure server-side implementation detail with no effect on the public API surface.

Analysis

  • The Python SDK has no accounts subclient, no with_traits query parameter handling, and no references to append_legacy or GroupTraits anywhere in the codebase
  • The diff does not change any endpoint paths, request parameters, or response schema that the SDK exposes or documents
  • No SDK files (source, tests, examples) require modification
Original prompt

This section details on the original issue you should resolve

<issue_title>Update Python SDK: blueink-core production 7e494c9</issue_title>
<issue_description>## Auto-update Python SDK from blueink-core API changes

A push to the production branch of blueink-core included changes in
signasure/apiv2/. Please update the Python SDK in this repository to
reflect these API changes.

Instructions

  1. Review the diff of signasure/apiv2/ below.
  2. Update any files in this repo necessary to reflect the API changes, including
    source files, tests, and examples.
  3. Make sure all updated methods, parameters, and models are consistent with the diff.

Diff of signasure/apiv2/

diff --git a/signasure/apiv2/internal/serializers.py b/signasure/apiv2/internal/serializers.py
index e7e9c53..b0accaf 100644
--- a/signasure/apiv2/internal/serializers.py
+++ b/signasure/apiv2/internal/serializers.py
@@ -199,9 +199,7 @@ class AccountV2Serializer(serializers.ModelSerializer):
 
         traits = {}
         if self.context.get(AccountViewSetV2.PARAM_WITH_TRAITS):
-            traits = GroupTraits.from_account(
-                account, append_legacy=settings.SEGMENT_APPEND_LEGACY_TRAITS
-            ).model_dump()
+            traits = GroupTraits.from_account(account).model_dump()
 
         return traits
 

</issue_description>

Comments on the Issue (you are @copilot in this section)

  • Fixes blueinkhq/blueink-client-python#32

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Update Python SDK to reflect blueink-core API changes No SDK changes required: internal server-side trait serializer cleanup Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants