fix: resolve bugs and improve code quality across the codebase#8
Merged
Conversation
- Fix render data bug: use conf (with defaults) instead of raw config for returned iterations/average values in testRenderTime (browser.ts) - Fix property name mismatch: server reads payload.average instead of payload.averages to match what the browser sends (index.ts) - Add BundleConfig type annotation to bundlePerformancePlugin parameter - Add explicit types to measureRenderTime session and payload parameters - Fix shadowed path variable in performanceReporter (rename to reportPath) and use path.join for proper path construction - Replace `as any` cast with type guard for CSS asset detection - Add try/finally around rolldown pipeline to ensure bundle.close() runs - Add timeout to measureElementRender to prevent hanging promises - Add store reset after reporter writes to prevent data bleed across runs - Fix LICENSE.md -> LICENSE in package.json files array - Add tests for store accumulation, store reset, and RegExp alias patterns - Add browser test for default testRenderTime config values - Update test payloads to use correct property name (average vs averages) https://claude.ai/code/session_01Qx5BGgWeYmPTnb8kwb56rg
40761c3 to
83f7eec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for returned iterations/average values in testRenderTime (browser.ts)
payload.averages to match what the browser sends (index.ts)
and use path.join for proper path construction
as anycast with type guard for CSS asset detectionhttps://claude.ai/code/session_01Qx5BGgWeYmPTnb8kwb56rg