[Backport] Fix thumbnail dashboard card#3850
Open
joaoantoniocardoso wants to merge 2 commits intobluerobotics:1.4from
Open
[Backport] Fix thumbnail dashboard card#3850joaoantoniocardoso wants to merge 2 commits intobluerobotics:1.4from
joaoantoniocardoso wants to merge 2 commits intobluerobotics:1.4from
Conversation
…gation on controls Prevents the play/camera buttons from triggering navigation to the Video Manager page when the thumbnail is embedded in the dashboard. Closes bluerobotics#3848
…thin parent Constrain the thumbnail frame height to its parent and use object-fit contain so the full image is visible without overflow or cropping.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBackports video thumbnail interaction and layout improvements to 1.4 by preventing thumbnail control clicks from bubbling to parent navigation and adjusting thumbnail image sizing to fully fit within its card. Sequence diagram for updated video thumbnail click handlingsequenceDiagram
actor User
participant ParentCard as ParentCardRouterLink
participant VideoThumbnail
participant ThumbnailControls
participant Router
User->>ParentCard: click on card area
ParentCard->>Router: navigate to video detail
User->>ThumbnailControls: click play or camera button
ThumbnailControls->>ThumbnailControls: @click.stop.prevent
ThumbnailControls-->>VideoThumbnail: emit play_or_camera_event
VideoThumbnail-->>Router: no navigation triggered
VideoThumbnail-->>User: video or camera action executed without leaving page
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider moving the inline
style="width: 100%; height: 100%; object-fit: contain;"on the<img>into a CSS class so that thumbnail layout behavior is centralized and easier to maintain.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider moving the inline `style="width: 100%; height: 100%; object-fit: contain;"` on the `<img>` into a CSS class so that thumbnail layout behavior is centralized and easier to maintain.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
object-fit: containso the full image fits within its parentTest plan
Summary by Sourcery
Backport video thumbnail interaction and layout improvements to the 1.4 branch.
Bug Fixes:
Enhancements: