frontend: components: video-manager: VideoStreamCreationDialog: Fix form state reset#3855
Closed
joaoantoniocardoso wants to merge 1 commit intobluerobotics:masterfrom
Closed
Conversation
…orm state reset Fix stale form state on dialog reopen by re-syncing all fields from the stream prop via a watcher.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a watcher on the dialog visibility flag to reset the video stream creation form from the current stream data whenever the dialog is opened, preventing stale form state when reopening the dialog. Sequence diagram for form reset on dialog reopensequenceDiagram
actor User
participant VideoStreamCreationDialog
participant Form
User->>VideoStreamCreationDialog: clickOpenDialog()
VideoStreamCreationDialog->>VideoStreamCreationDialog: set show = true
VideoStreamCreationDialog->>VideoStreamCreationDialog: watcher show(newVal)
alt newVal is true
VideoStreamCreationDialog->>VideoStreamCreationDialog: resetFormFromStream()
VideoStreamCreationDialog->>Form: populate fields from stream
end
User->>VideoStreamCreationDialog: closeDialogWithoutSaving()
VideoStreamCreationDialog->>VideoStreamCreationDialog: set show = false
User->>VideoStreamCreationDialog: clickOpenDialog()
VideoStreamCreationDialog->>VideoStreamCreationDialog: set show = true
VideoStreamCreationDialog->>VideoStreamCreationDialog: watcher show(newVal)
alt newVal is true
VideoStreamCreationDialog->>VideoStreamCreationDialog: resetFormFromStream()
VideoStreamCreationDialog->>Form: overwrite stale edits with current stream
end
Class diagram for VideoStreamCreationDialog watcher additionclassDiagram
class VideoStreamCreationDialog {
+boolean show
+VForm form
+resetFormFromStream() void
+watch_show(newVal boolean) void
}
class VForm {
}
VideoStreamCreationDialog ..> VForm : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Member
Author
|
Closing: the watch block already exists on master (merged via an earlier PR). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Summary by Sourcery
Bug Fixes: