Skip to content

Frontend: allow calibrating without a global position, add warning #3982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Williangalvani wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Frontend: allow calibrating without a global position, add warning #3982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions core/frontend/src/components/vehiclesetup/configuration/compass/FullCompassCalibrator.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
readings to the expected local magnetic field.
</p>
<p>
A valid global region/position is <strong>recomended</strong> for Onboard Calibration to
A valid global region/position is <strong>recommended</strong> for Onboard Calibration to
estimate the local world magnetic field.
</p>
</span>
Expand Down Expand Up @@ -76,12 +76,15 @@

<StatusTextWatcher :filter="/.*/" :style="`display : ${status_type === 'error' ? 'block' : 'none'};`" />
</v-card-text>
<v-alert v-if="!coordinates" type="warning" dense text class="text-caption mx-4 mb-0">
Calibration without a valid global region/position is not recommended.
</v-alert>
<v-card-actions>
<v-spacer />
<v-btn
v-if="state !== states.CALIBRATING && state !== states.FAILED"
color="primary"
:disabled="!compass_mask || !coordinates"
:disabled="!compass_mask"
@click="calibrate()"
>
Calibrate
Expand Down
Loading