[backport/1.4] fix: detect Raspberry Pi Compute Module 4/5 in get_cpu_type() - #4077
Draft
joaoantoniocardoso wants to merge 3 commits into
Draft
Conversation
get_cpu_type() greps /proc/cpuinfo for the literal strings "Raspberry Pi 4" / "Raspberry Pi 5", but Compute Modules report themselves as "Raspberry Pi Compute Module 4/5", so CM4/CM5 returned CpuType.Other and Navigator detection never ran. Accept the Compute Module model strings as PI4/PI5 and add a regression test. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Importing general.py in the new test_general.py pulled general.py and commands.py into the coverage measurement for the first time, dropping total coverage below the 75% gate (72.43% in CI). Cover the remaining general.py helpers (host OS detection, file deletion, lsof-based open checks, local identifiers, device id) to clear the gate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
joaoantoniocardoso
added
the
merge-after-stable
1.4's delete_everything has no ignore= kwarg, and file_is_open helpers differ from master. Drop/adjust those cases so pylint and pytest pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #4011 into 1.4.