frontend: serve Draco decoder locally for offline 3D models - #4086
Open
Williangalvani wants to merge 1 commit into
Open
frontend: serve Draco decoder locally for offline 3D models#4086Williangalvani wants to merge 1 commit into
Williangalvani wants to merge 1 commit into
Conversation
model-viewer defaults to a Google CDN for Draco; without internet the vehicle models never decode. Bundle three's decoder and point both model-viewer and OrientationPicker at it.
Automated PR Review0. Summary
Bundles the Draco decoder from No further comments, nice job 👍 Generated by PR Review Bot. This is advisory, a human reviewer must still approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3337
model-viewer defaults to a Google CDN for Draco; without internet the vehicle models never decode. Bundle three's decoder and point both model-viewer and OrientationPicker at it.
tested by connecting via hotspot