v0.3.0#7
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project documentation and architecture to reflect a major recalibration of the code analysis rules, with a focus on governing AI-generated code for human verifiability. It introduces two new ADRs: one that formally states the project's mission, and another that removes the
complexity.npathrule and tightens complexity thresholds to better align with that mission. The documentation and rule catalog are updated accordingly, including rule counts and severity adjustments.Key changes:
Mission and Project Direction
.goat-flow/architecture.mdand documented indocs/mission.md. [1] [2]Complexity Rule Recalibration
Added ADR-018, which retires the
complexity.npathrule (breaking change), demoteshalstead-volumeandmaintainability-indexto advisory severity, tightens cognitive complexity (error at 20) and nesting depth (error at 4), and makes cyclomatic complexity a warning (at 20). This aligns the complexity pillar with the project's verifiability mission.Updated the rule catalog in
.goat-flow/architecture.mdto reflect the removal ofcomplexity.npath(complexity pillar now has 4 rules, not 5), and updated the total rule count from 119 to 118. The description of complexity rules now matches the new severities and thresholds.Updated
.goat-flow/code-map.mdto remove the mapping forNpathComplexityRule.php, confirming the rule's retirement.Documentation and Metadata Updates
Updated the version constant in the architecture documentation to
0.2.0and clarified the summary digest version for thesummarycommand. [1] [2]Corrected the documentation of the
Findingobject'sstableIdentitycalculation to match implementation changes.Added documentation for the
minimumSeverityconfig option, clarifying its usage and validation.Summary by CodeRabbit
New Features
Breaking Changes
Updates
Note
Medium Risk
Hook and settings changes affect agent command blocking and post-edit behavior repo-wide; misconfiguration or missing hook-lib could fail closed or skip guards until setup is rerun.
Overview
goat-flow 1.9.0 bumps every
goat-*skill (and mirrored.claude/skills) and tightens how agents report evidence: critique, QA, and security outputs now require proof class tags (RUNTIME | CONTRACT-GREP | STATIC | NOT-REPRODUCED), risk-agent context uses grep-first footgun/lesson hits instead of whole-bucket reads, and goat-review PR mode adds an automated-reviewer overlap protocol (references/automated-review.md) with[overlap:bot]/[new]tagging plus richergh pr viewJSON.Planning and QA get lighter wording in goat-plan (milestone filename/presentation examples) and goat-qa (condensed intake tables and proof-class columns in output templates). goat-security drops
GEMINI.mdfrom the agent-surface scan list and adds proof-class fields to findings and integrity sections.Hooks:
deny-dangerous.shis rebuilt as a dispatcher that loads.goat-flow/hook-lib/(patterns-shell,patterns-paths,patterns-writes), resolves repo root via git, supports Copilot and Antigravity JSON deny shapes, and delegates self-tests to.goat-flow/hook-lib/deny-dangerous-self-test.sh(replacing the inlined.claude/hooks/deny-dangerous.self-test.sh). Newgruff-code-quality.shruns gruff on changed lines only after Edit/Write/MultiEdit;.claude/settings.jsonwires it on PostToolUse and hardens PreToolUse hook paths with git-common-dir root resolution.Reviewed by Cursor Bugbot for commit 23df30b. Bugbot is set up for automated code reviews on this repo. Configure here.