fix(bmad-investigate): keep method-internal vocabulary out of user-facing output#2478
Closed
mc856 wants to merge 1 commit into
Closed
fix(bmad-investigate): keep method-internal vocabulary out of user-facing output#2478mc856 wants to merge 1 commit into
mc856 wants to merge 1 commit into
Conversation
…cing output The Outcome 1 recap instruction told the agent to present "stronghold" verbatim in chat, leaking internal method language to the user. Add a Communication guardrail, reword the recap line to plain English, and tighten the frontmatter trigger to explicit invocation only. Fixes bmad-code-org#2452.
mc856
force-pushed
the
fix/bmad-investigate-stronghold-leak
branch
from
39fe4bf to
ad6ae7e
Compare
alexeyv
added a commit
that referenced
this pull request
Jun 25, 2026
* chore(bmm): retire bmad-investigate skill and its documentation
Removes the bmad-investigate skill, its case-file template, the EN/FR
forensic-investigation explainer docs, and every integration point:
Amelia's `IN` menu entry, the plugin marketplace manifest, module-help,
the workflow-map tables and HTML diagrams, and the agent-trigger tables.
EN/FR explanation sidebar orders are renumbered to close the gap left by
the removed doc.
Rationale: the skill's only non-redundant value was a durable, hand-off
case-file artifact — a workflow that is unproven in practice. Everything
else (evidence grading, hypothesis discipline, causal tracing) is
behavior a capable model already performs without a dedicated skill. The
skill also carried method-internal metaphor ("stronghold", "evidence
perimeter") that leaked into user-facing chat. Upstream signals agreed:
issue #2452 flagged the vocabulary leak and a maintainer noted the skill
should not auto-fire. Added in #2364.
Supersedes the in-flight cleanup in #2478 and resolves #2452 by removal.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* chore(bmm): add bmad-investigate to removals.txt and note retirement
The retirement commit removed the skill source and docs but did not add
the removals.txt entry that triggers cleanup of the skill directory on
existing installs during update. Add it, plus an Unreleased CHANGELOG note.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
@coderabbitai review |
Collaborator
|
The skill is gone, so this is now moot. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
Changesbmad-investigate wording updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two related fixes in
bmad-investigate, both addressing #2452:How
Three edits to
src/bmm-skills/4-implementation/bmad-investigate/SKILL.md:descriptionrewritten to match the house style used bybmad-code-review,bmad-create-story, etc. — quoted explicit invocation phrases ("bmad investigate","open an investigation"). Drops broad-paraphrase triggers like"walk through unfamiliar code"/"build a mental model".present scope, stronghold, file pathtopresent scope, the confirmed starting evidence, file path— the exact phrasing the issue author suggested.Notes
Stronghold first.principle (line 32), the Outcome 1 heading, and the "find the stronghold" instructions in Outcome 1's body are unchanged. Per the issue author's preference, this PR fixes the chat-output leak via guardrail rather than renaming the method's internal language. Whether to renameStronghold first.itself is a separate question, fit for a follow-up PR if you want it.Verification
node tools/validate-skills.js --json src/bmm-skills/4-implementation/bmad-investigate→[]npm ci && npm run quality→Errors: 0(23 unrelatedvi-vn/zh-cnsidebar-order warnings)Opening as draft to get a quick direction-check on the new trigger phrasing before polish.