feat(dev-auto): route done spec to a follow-up review pass#2508
Conversation
Invoking the skill on a spec with status `done` now resets `review_loop_iteration` and routes to step-04 for a fresh review pass, instead of ingesting the spec as context. This lets an orchestrator layer follow-up reviews on a completed spec without another skill. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🤖 Augment PR SummarySummary: Re-invoking 🤖 Was this summary useful? React with 👍 or 👎 |
| - `in-review` → `./step-04-review.md` | ||
| - `blocked` → HALT with status `blocked` and blocking condition `blocked spec supplied`. | ||
| - `done` → ingest as context and proceed to INSTRUCTIONS — do not resume. | ||
| - `done` → set `review_loop_iteration` to `0` in the frontmatter, then **EARLY EXIT** to `./step-04-review.md` for a fresh review pass. (A `done` spec is a completed run, so this starts a follow-up review, not a resumption.) |
There was a problem hiding this comment.
set review_loop_iteration to 0 in the frontmatter could be misread as this step file’s frontmatter rather than the referenced spec’s ({spec_file}) frontmatter. Consider clarifying that the updated frontmatter must be written back to {spec_file} before the EARLY EXIT to step-04.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdates the step-01 routing for ChangesDone-spec review reroute
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5–15 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Re-invoking
bmad-dev-autoon a spec withstatus: donenow starts a fresh review pass instead of ingesting the spec as context.In step-01's status router, the
doneroute changes from "ingest as context and proceed to INSTRUCTIONS — do not resume" to: resetreview_loop_iterationto0, then route directly to step-04 (review).Why
After a successful run the spec ends at
status: done— the one terminal state with no path back into review. step-04 is already built for repeated, independent passes (review subagents get no prior context, the diff is reconstructed frombaseline_revision, the triage log is keyed per pass, and Finalize already emitsfollowup_review_recommended). This change opens the only missing door, so an orchestrator can layer follow-up reviews on a completed spec — gated onfollowup_review_recommended— without invoking another skill.The previous
done-as-context behavior was redundant: step-01's Previous story continuity step already pulls prior same-epicdonespecs into planning automatically.Note on the counter reset
The reset lives in the
doneroute only. Thein-reviewroute is a resumption of an interrupted pass and keeps its counter, preserving the non-convergence guard (HALT after 5 bad_spec loopbacks). Adonere-invocation is a new pass, so it starts the clock fresh.🤖 Generated with Claude Code