Skip to content

feat(dev-auto): route done spec to a follow-up review pass#2508

Merged
alexeyv merged 1 commit into
mainfrom
feat/dev-auto-followup-review
Jun 24, 2026
Merged

feat(dev-auto): route done spec to a follow-up review pass#2508
alexeyv merged 1 commit into
mainfrom
feat/dev-auto-followup-review

Conversation

@alexeyv

@alexeyv alexeyv commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

What

Re-invoking bmad-dev-auto on a spec with status: done now starts a fresh review pass instead of ingesting the spec as context.

In step-01's status router, the done route changes from "ingest as context and proceed to INSTRUCTIONS — do not resume" to: reset review_loop_iteration to 0, then route directly to step-04 (review).

Why

After a successful run the spec ends at status: done — the one terminal state with no path back into review. step-04 is already built for repeated, independent passes (review subagents get no prior context, the diff is reconstructed from baseline_revision, the triage log is keyed per pass, and Finalize already emits followup_review_recommended). This change opens the only missing door, so an orchestrator can layer follow-up reviews on a completed spec — gated on followup_review_recommended — without invoking another skill.

The previous done-as-context behavior was redundant: step-01's Previous story continuity step already pulls prior same-epic done specs into planning automatically.

Note on the counter reset

The reset lives in the done route only. The in-review route is a resumption of an interrupted pass and keeps its counter, preserving the non-convergence guard (HALT after 5 bad_spec loopbacks). A done re-invocation is a new pass, so it starts the clock fresh.

🤖 Generated with Claude Code

Invoking the skill on a spec with status `done` now resets
`review_loop_iteration` and routes to step-04 for a fresh review pass,
instead of ingesting the spec as context. This lets an orchestrator
layer follow-up reviews on a completed spec without another skill.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@alexeyv alexeyv merged commit d5c5cc7 into main Jun 24, 2026
7 checks passed
@alexeyv alexeyv deleted the feat/dev-auto-followup-review branch June 24, 2026 23:13
@augmentcode

augmentcode Bot commented Jun 24, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Re-invoking bmad-dev-auto on a completed (status: done) spec now starts a fresh review pass instead of ingesting the spec as context.
Changes: Updates step-01 routing to reset review_loop_iteration to 0 and early-exit directly to step-04-review.md for follow-up reviews.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

- `in-review` → `./step-04-review.md`
- `blocked` → HALT with status `blocked` and blocking condition `blocked spec supplied`.
- `done` → ingest as context and proceed to INSTRUCTIONS — do not resume.
- `done` → set `review_loop_iteration` to `0` in the frontmatter, then **EARLY EXIT** to `./step-04-review.md` for a fresh review pass. (A `done` spec is a completed run, so this starts a follow-up review, not a resumption.)

@augmentcode augmentcode Bot Jun 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set review_loop_iteration to 0 in the frontmatter could be misread as this step file’s frontmatter rather than the referenced spec’s ({spec_file}) frontmatter. Consider clarifying that the updated frontmatter must be written back to {spec_file} before the EARLY EXIT to step-04.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b53461dd-2d81-4ea8-8e15-2c935693400a

📥 Commits

Reviewing files that changed from the base of the PR and between f04260b and 4d145b3.

📒 Files selected for processing (1)
  • src/bmm-skills/4-implementation/bmad-dev-auto/step-01-clarify-and-route.md

📝 Walkthrough

Walkthrough

Updates the step-01 routing for done specs so the workflow resets review_loop_iteration to 0 and early exits to ./step-04-review.md instead of continuing into INSTRUCTIONS.

Changes

Done-spec review reroute

Layer / File(s) Summary
Reset review loop and route to step 04
src/bmm-skills/4-implementation/bmad-dev-auto/step-01-clarify-and-route.md
The done branch now updates frontmatter with review_loop_iteration: 0 and switches control flow to an early exit targeting ./step-04-review.md.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–15 minutes

Possibly related PRs

  • bmad-code-org/BMAD-METHOD#2500: Changes bmad-dev-auto/step-01-clarify-and-route.md routing for status: done, including the review-loop reset and next-step selection.
  • bmad-code-org/BMAD-METHOD#2501: Adjusts the step-01 review-loop control to initialize review_loop_iteration and route into step-04-review.md.
  • bmad-code-org/BMAD-METHOD#2506: Updates step-04-review.md finalize/commit behavior, which is directly connected to the reroute into that step.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: rerouting done specs into a follow-up review pass.
Description check ✅ Passed The description directly matches the changeset and explains the routing and counter reset behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/dev-auto-followup-review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant