fix: make release dry-run checks executable - #246
Open
bmarwell wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=======================================
Coverage 72.11% 72.11%
=======================================
Files 26 26
Lines 563 563
Branches 52 52
=======================================
Hits 406 406
Misses 128 128
Partials 29 29 ☔ View full report in Codecov by Harness. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release dry-run verification script and related documentation to correctly detect required Maven/JReleaser configuration and run non-interactively, aligning the process with the repository’s jreleaser.toml setup.
Changes:
- Fix Maven release plugin detection by inspecting the effective POM without quiet mode and without
grep -q(to avoidpipefail/SIGPIPE issues). - Run
mvn release:preparein batch mode (-B) to keep dry-runs non-interactive. - Update release documentation/comments to reference
jreleaser.tomlinstead of the retiredjreleaser.yml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test-release.sh | Adjusts dry-run checks: effective POM inspection, batch-mode release prepare, and TOML config file validation. |
| RELEASING.adoc | Updates troubleshooting guidance to reference jreleaser.toml. |
| cli/pom.xml | Updates an explanatory comment to reference jreleaser.toml distribution expectations. |
|
|
||
| check_maven_release_plugin() { | ||
| ./mvnw help:effective-pom -q | grep -q "maven-release-plugin" && return 0 | ||
| ./mvnw help:effective-pom | grep -F "maven-release-plugin" > /dev/null && return 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #244.
pipefailSIGPIPE.release:preparein batch mode for non-interactive dry runs.jreleaser.toml.