Skip to content

fix: make release dry-run checks executable - #246

Open
bmarwell wants to merge 3 commits into
mainfrom
fix/244-release-plugin-check
Open

fix: make release dry-run checks executable#246
bmarwell wants to merge 3 commits into
mainfrom
fix/244-release-plugin-check

Conversation

@bmarwell

Copy link
Copy Markdown
Owner

Fixes #244.

  • Detect the Maven release plugin from the effective POM without suppressing its output or triggering a pipefail SIGPIPE.
  • Run release:prepare in batch mode for non-interactive dry runs.
  • Align JReleaser validation and documentation with jreleaser.toml.

bmarwell and others added 3 commits July 28, 2026 17:50
Fixes #244

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixes #244

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixes #244

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 28, 2026 15:58
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.11%. Comparing base (caa4e09) to head (5d71841).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   72.11%   72.11%           
=======================================
  Files          26       26           
  Lines         563      563           
  Branches       52       52           
=======================================
  Hits          406      406           
  Misses        128      128           
  Partials       29       29           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release dry-run verification script and related documentation to correctly detect required Maven/JReleaser configuration and run non-interactively, aligning the process with the repository’s jreleaser.toml setup.

Changes:

  • Fix Maven release plugin detection by inspecting the effective POM without quiet mode and without grep -q (to avoid pipefail/SIGPIPE issues).
  • Run mvn release:prepare in batch mode (-B) to keep dry-runs non-interactive.
  • Update release documentation/comments to reference jreleaser.toml instead of the retired jreleaser.yml.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
test-release.sh Adjusts dry-run checks: effective POM inspection, batch-mode release prepare, and TOML config file validation.
RELEASING.adoc Updates troubleshooting guidance to reference jreleaser.toml.
cli/pom.xml Updates an explanatory comment to reference jreleaser.toml distribution expectations.

Comment thread test-release.sh

check_maven_release_plugin() {
./mvnw help:effective-pom -q | grep -q "maven-release-plugin" && return 0
./mvnw help:effective-pom | grep -F "maven-release-plugin" > /dev/null && return 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix release plugin detection in dry-run script

2 participants