Ebajrami/issue 176#179
Merged
Merged
Conversation
ebajrami
requested review from
4ndrey,
JanMichaelPeter,
dominik089 and
robert-northmind
as code owners
ebajrami
added
the
ready for pipeline
ebajrami
force-pushed
the
ebajrami/issue-176
branch
2 times, most recently
from
6f022b5 to
efa1f0b
Compare
ebajrami
force-pushed
the
ebajrami/issue-176
branch
from
efa1f0b to
6600e1d
Compare
4ndrey
previously approved these changes
May 23, 2025
dominik089
reviewed
May 23, 2025
Collaborator
dominik089
left a comment
dominik089
left a comment
There was a problem hiding this comment.
I left some comments (mostly linting) regarding the shellscripts
ebajrami
force-pushed
the
ebajrami/issue-176
branch
3 times, most recently
from
e78d1a1 to
91bf060
Compare
Collaborator
robert-northmind
left a comment
robert-northmind
left a comment
There was a problem hiding this comment.
LGTM if you fix Dominik's comments.
Nice work 🥳
ebajrami
force-pushed
the
ebajrami/issue-176
branch
5 times, most recently
from
52d4abe to
3e66a41
Compare
ebajrami
force-pushed
the
ebajrami/issue-176
branch
4 times, most recently
from
7ed7091 to
18f1eab
Compare
robert-northmind
previously approved these changes
May 26, 2025
ebajrami
force-pushed
the
ebajrami/issue-176
branch
from
18f1eab to
1c3b2f7
Compare
4ndrey
approved these changes
May 26, 2025
robert-northmind
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update for the PR #177
Type of Change
Since publishing can be only triggered based on the git tag, we are adding two things here: