Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5302 +/- ##
===========================================
+ Coverage 47.24% 59.73% +12.49%
===========================================
Files 476 589 +113
Lines 46892 63487 +16595
===========================================
+ Hits 22154 37926 +15772
- Misses 24738 25561 +823 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| r#" | ||
| let threw = false; | ||
| try { | ||
| Response.redirect("/foo"); |
There was a problem hiding this comment.
need adjusting (see comments in #5301. )
this should not throw.
There was a problem hiding this comment.
yeah I'll push the commit by night was working on something else
There was a problem hiding this comment.
I rechecked this more carefully. The spec parses against the current settings objects API base URL, so I think the /foo case depends on the host environment. that should explain why it works in your browser console ss while node and boa CLI both throw here
The part this PR is fixing is narrower: Location should use the serialized parsed url
@jedel1043 what do you think about keeping this PR scoped to that part ??
Fixes #5301.
Response.redirect()was validating the input with a generic URI check and then writing the original string into theLocationheader. That meant absolute URLs were not serialized, and relative URLs like/foowere accepted.This changes
Response.redirect()to parse the target as a URL and store the serialized parsed URL inLocation. It also enables theurldependency under thefetchfeature so the non-default build stays correct.Tests cover:
Checks: