Skip to content

Fix a spec violation in Date.prototype.toLocaleString #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vellumic wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −18
Open

Fix a spec violation in Date.prototype.toLocaleString #5324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2289a37
Fix a spec violation in `Date.prototype.toLocaleString`
Vellumic Apr 12, 2026
ff676cd
Add test
Vellumic Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions core/engine/src/builtins/intl/date_time_format/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,24 +1025,6 @@ pub(crate) fn format_date_time_locale(
context: &mut Context,
) -> JsResult<JsValue> {
let options = coerce_options_to_object(options, context)?;
if format_type != FormatType::Time
&& get_option::<DateStyle>(&options, js_string!("dateStyle"), context)?.is_none()
{
options.create_data_property_or_throw(
js_string!("dateStyle"),
JsValue::from(js_string!("long")),
context,
)?;
}
if format_type != FormatType::Date
&& get_option::<TimeStyle>(&options, js_string!("timeStyle"), context)?.is_none()
{
options.create_data_property_or_throw(
js_string!("timeStyle"),
JsValue::from(js_string!("long")),
context,
)?;
}
let options_value = options.into();
let dtf = create_date_time_format(locales, &options_value, format_type, defaults, context)?;
// FormatDateTime steps 1–2: TimeClip and NaN check (format_timestamp_with_dtf does ToLocalTime + format only).
Expand Down
23 changes: 23 additions & 0 deletions core/engine/src/builtins/intl/date_time_format/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,26 @@ fn dtf_basic() {
TestAction::assert_eq("result === 'Sunday, 20 December 2020 at 14:23:16'", true),
]);
}

#[cfg(feature = "intl_bundled")]
#[test]
fn date_to_locale_string() {
run_test_actions([
TestAction::run(indoc! {"
// Setup date
const date = new Date(Date.UTC(2021, 3, 12, 6, 7));

let result = date.toLocaleString('en-US', { dateStyle: 'short' });
"}),
TestAction::assert_eq("result === '4/12/21'", true),
]);
run_test_actions([
TestAction::run(indoc! {"
// Setup date
const date = new Date(Date.UTC(2021, 3, 12, 6, 7));

let result = date.toLocaleString('en-US', { timeStyle: 'short' });
"}),
TestAction::assert_eq("result === '6:07\u{202f}AM'", true),
]);
}
Loading