test(regexp): enable duplicate named capturing groups tests#5327
Closed
tkshsbcue wants to merge 1 commit intoboa-dev:mainfrom
Closed
test(regexp): enable duplicate named capturing groups tests#5327tkshsbcue wants to merge 1 commit intoboa-dev:mainfrom
tkshsbcue wants to merge 1 commit intoboa-dev:mainfrom
Conversation
Remove `regexp-duplicate-named-groups` from the ignored features list and remove the individual test skip for `non-unicode-property-names-valid.js`. The `regress` crate v0.11.1 (already in our dependencies) implements duplicate named capturing groups, so these tests should now pass. Closes boa-dev#4442.
Test262 conformance changes
Fixed tests (14):Tested main commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5327 +/- ##
===========================================
+ Coverage 47.24% 59.78% +12.54%
===========================================
Files 476 590 +114
Lines 46892 63695 +16803
===========================================
+ Hits 22154 38080 +15926
- Misses 24738 25615 +877 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Duplicate of #4550 |
Contributor
Author
|
sorry my bad i thought this could be better implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test(regexp): enable duplicate named capturing groups tests
Closes #4442.
The
regresscrate v0.11.1 (already in our dependencies) supports duplicate named capturing groups. This removes the feature skip and individual test skip that were blocking test262 coverage for this Stage 4 proposal.Changes
"regexp-duplicate-named-groups"from ignored features intest262_config.tomlnon-unicode-property-names-valid.jstest skip (its TODO comment says to remove once regress fixes named groups parsing, which v0.11 did)The
SpecEdition::ES16mapping inedition.rswas already in place.