Skip to content

test(regexp): enable duplicate named capturing groups tests#5327

Closed
tkshsbcue wants to merge 1 commit intoboa-dev:mainfrom
tkshsbcue:feat/enable-regexp-duplicate-named-groups
Closed

test(regexp): enable duplicate named capturing groups tests#5327
tkshsbcue wants to merge 1 commit intoboa-dev:mainfrom
tkshsbcue:feat/enable-regexp-duplicate-named-groups

Conversation

@tkshsbcue
Copy link
Copy Markdown
Contributor

test(regexp): enable duplicate named capturing groups tests

Closes #4442.

The regress crate v0.11.1 (already in our dependencies) supports duplicate named capturing groups. This removes the feature skip and individual test skip that were blocking test262 coverage for this Stage 4 proposal.

Changes

  • Remove "regexp-duplicate-named-groups" from ignored features in test262_config.toml
  • Remove the non-unicode-property-names-valid.js test skip (its TODO comment says to remove once regress fixes named groups parsing, which v0.11 did)

The SpecEdition::ES16 mapping in edition.rs was already in place.

Remove `regexp-duplicate-named-groups` from the ignored features list
and remove the individual test skip for `non-unicode-property-names-valid.js`.

The `regress` crate v0.11.1 (already in our dependencies) implements
duplicate named capturing groups, so these tests should now pass.

Closes boa-dev#4442.
@tkshsbcue tkshsbcue requested a review from a team as a code owner April 13, 2026 09:31
@github-actions github-actions bot added Waiting On Review Waiting on reviews from the maintainers C-Tests Issues and PRs related to the tests. and removed Waiting On Review Waiting on reviews from the maintainers labels Apr 13, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Apr 13, 2026
@github-actions
Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 53,125 53,125 0
Passed 51,049 51,063 +14
Ignored 1,482 1,462 -20
Failed 594 600 +6
Panics 0 0 0
Conformance 96.09% 96.12% +0.03%
Fixed tests (14):
test/staging/built-ins/RegExp/named-groups/duplicate-named-groups-search.js (previously Ignored)
test/built-ins/String/prototype/match/duplicate-named-groups-properties.js (previously Ignored)
test/built-ins/String/prototype/match/duplicate-named-indices-groups-properties.js (previously Ignored)
test/built-ins/RegExp/duplicate-named-capturing-groups-syntax.js (previously Ignored)
test/built-ins/RegExp/named-groups/duplicate-names-replace.js (previously Ignored)
test/built-ins/RegExp/named-groups/duplicate-names-match-indices.js (previously Ignored)
test/built-ins/RegExp/named-groups/duplicate-names-split.js (previously Ignored)
test/built-ins/RegExp/named-groups/duplicate-names-group-property-enumeration-order.js (previously Ignored)
test/built-ins/RegExp/named-groups/duplicate-names-search.js (previously Ignored)
test/built-ins/RegExp/named-groups/duplicate-names-replaceall.js (previously Ignored)
test/built-ins/RegExp/named-groups/duplicate-names-matchall.js (previously Ignored)
test/built-ins/RegExp/prototype/exec/duplicate-named-groups-properties.js (previously Ignored)
test/built-ins/RegExp/prototype/exec/duplicate-named-indices-groups-properties.js (previously Ignored)
test/annexB/built-ins/RegExp/prototype/compile/duplicate-named-capturing-groups-syntax.js (previously Ignored)

Tested main commit: 3cec5e6bc4454077cb8d65b537d368d633137e0e
Tested PR commit: 4c64386c9f84cd489c814d33086484069fe15e7f
Compare commits: 3cec5e6...4c64386

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.78%. Comparing base (6ddc2b4) to head (4c64386).
⚠️ Report is 951 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5327       +/-   ##
===========================================
+ Coverage   47.24%   59.78%   +12.54%     
===========================================
  Files         476      590      +114     
  Lines       46892    63695    +16803     
===========================================
+ Hits        22154    38080    +15926     
- Misses      24738    25615      +877     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jedel1043
Copy link
Copy Markdown
Member

Duplicate of #4550

@jedel1043 jedel1043 marked this as a duplicate of #4550 Apr 13, 2026
@jedel1043 jedel1043 closed this Apr 13, 2026
@tkshsbcue
Copy link
Copy Markdown
Contributor Author

sorry my bad i thought this could be better implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Tests Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement duplicated named capturing groups proposal

2 participants