Skip to content

Align Intl.DateTimeFormat constructor with spec-mandated initialization order#5336

Open
Vellumic wants to merge 3 commits intoboa-dev:mainfrom
Vellumic:fix/intl-dtf-ctor-observable-behavior
Open

Align Intl.DateTimeFormat constructor with spec-mandated initialization order#5336
Vellumic wants to merge 3 commits intoboa-dev:mainfrom
Vellumic:fix/intl-dtf-ctor-observable-behavior

Conversation

@Vellumic
Copy link
Copy Markdown
Contributor

@Vellumic Vellumic commented Apr 15, 2026

This Pull Request fixes/closes #5335.

It changes the following:

  • Swap the prototype lookup and DateTimeFormat creation to match the spec steps order
  • Add a regression test for this specific case
  • Add a step 1 from spec to create_date_time_format as well as comment about why it's missing

Validation

  • Run (all passed)
cargo test --package boa_engine --lib --features intl_bundled -- builtins::intl::date_time_format::tests --nocapture

NOTE: This should be merged after #5324.

@github-actions github-actions bot added Waiting On Review Waiting on reviews from the maintainers C-Tests Issues and PRs related to the tests. C-Builtins PRs and Issues related to builtins/intrinsics C-Intl Changes related to the `Intl` implementation labels Apr 15, 2026
@github-actions github-actions bot added this to the v1.0.0 milestone Apr 15, 2026
@github-actions
Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 53,125 53,125 0
Passed 51,049 51,049 0
Ignored 1,482 1,482 0
Failed 594 594 0
Panics 0 0 0
Conformance 96.09% 96.09% 0.00%

Tested main commit: da570fd74bb6cd5b0fc01363451eb710b7ab5a0c
Tested PR commit: a3edd2fac13ec042f07237fcdac93e493bdde39d
Compare commits: da570fd...a3edd2f

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.76%. Comparing base (6ddc2b4) to head (a3edd2f).
⚠️ Report is 954 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5336       +/-   ##
===========================================
+ Coverage   47.24%   59.76%   +12.52%     
===========================================
  Files         476      590      +114     
  Lines       46892    63683    +16791     
===========================================
+ Hits        22154    38062    +15908     
- Misses      24738    25621      +883     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Builtins PRs and Issues related to builtins/intrinsics C-Intl Changes related to the `Intl` implementation C-Tests Issues and PRs related to the tests. Waiting On Review Waiting on reviews from the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intl.DateTimeFormat constructor breaks the inheritance when passing wrong options

1 participant