Open
Conversation
bhirsz
reviewed
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find it very useful to have a feature to omit by linter the lines containing specific comment just like it works in pylama. The regex pattern is taken from pylama project — it's simple and works properly.
By putting a comment starting with noqa it is possible now to ignore these lines by linter. The problem is that some rules that report the issues on the first line of the element (keyword's name or test case's title) will not be displayed. Because of that I fixed TagWithSpaces rule to report the issue on the line where the tag appears and not on the line of the test case title. There may be some other rules that report wrong line number but it's the problem of the rule itself, not the feature.
I tried to implement the same feature here. Added also some test cases that verifies that it works well.