Merged
Conversation
Support multiple joysticks by saving the ID of the touch point when a canvas is touched. Then when a touch is ended anywhere in the document, each joystick compares the ended touch ID with the touch ID associated with its canvas to know whether to honor that touch end event.
|
Absolutely agree with you. This one looks like an easy and clean fix. Is anyone maintaining this repo? Would like to fix this officially on my side as well! They probably use this website to minify the js code. |
|
@bobboteck any plans on merging this ? This would be very helpful :) |
Owner
|
@top-kat @nguterresn @brollin sorry for late merge, but I'm too busy in this period of my life, can you test if all is ok? |
|
Tested everything is working fine :) Thanks a lot @bobboteck and good luck to handle everything ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw the other pull request for fixing this same problem, but I think this solution may be cleaner.
Support multiple joysticks by saving the ID of the touch point when a canvas is touched. Then when a touch is ended anywhere in the document, each joystick compares the ended touch ID with the touch ID associated with its canvas to know whether to honor that touch end event.
By the way, didn't see a way to generate the minified JS. Would recommend including a command to do so somewhere, perhaps as a npm script.