fix: replace Ollama curl installer with brew install to prevent CI failure - #19
Conversation
…aunch failure in CI Co-authored-by: bobbravo2 <348865+bobbravo2@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 611299100d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ! command -v ollama &>/dev/null; then | ||
| echo "🦙 Ollama not found. The work needs a local model stack. Installing..." | ||
| curl -fsSL https://ollama.com/install.sh | sh | ||
| brew install ollama |
There was a problem hiding this comment.
When users consult the install-method table, README.md:48 still directs them to the old curl ... | sh installer, which can reproduce the headless GUI-launch failure this change is intended to eliminate and contradicts the actual provisioning behavior. Update that row to show brew install ollama.
Useful? React with 👍 / 👎.
The macOS E2E CI job was failing because the Ollama curl installer downloads a
.appbundle and then callsopen -a Ollamato launch it — which errors out on headless runners withUnable to find application named 'Ollama'.Changes
install.sh: Replacecurl -fsSL https://ollama.com/install.sh | shwithbrew install ollama, which installs the CLI binary only and skips the GUI launch stepThis keeps the script consistent with how every other tool is installed (via Homebrew) and eliminates the dependency on the external installer's macOS-specific launch behavior.