This repository was archived by the owner on Mar 15, 2021. It is now read-only.
Fix: reRequiring files with naming collisions with mock-require#37
Open
treygriffith wants to merge 3 commits intoboblauer:masterfrom
Open
Fix: reRequiring files with naming collisions with mock-require#37treygriffith wants to merge 3 commits intoboblauer:masterfrom
treygriffith wants to merge 3 commits intoboblauer:masterfrom
Conversation
…e location to resolve from, rather than the mock-require module itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes #36 by making
require.resolveexplicit in where it is resolving from. It therefore prevents collisions with files inmock-require, which are themselves in theNODE_PATH, triggering theisInPathcondition to return themock-requirefile.To illustrate the change I moved the module itself to the
NODE_PATHfor the test.