Distinct types check#15
Merged
Merged
Conversation
bobozaur
force-pushed
the
type_list_checks
branch
from
9abf451 to
1ccbf85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps up the issue reported in #13 and partially addressed in #14. Another requirement to enforce should be that there are at least two distinct types in the type list. This ensures there's some valid conversion path to be taken and avoids infinite recursion.
This PR achieves that by checking that the first and last types in the list are distinct. This is sufficient since the derived type must have a direct conversion to one of them already and the macro generates the conversion to the other one, so having them equal makes no sense.